GNOME Bugzilla – Bug 702254
7.3.67.4: MediaExport does not provide <upnp:searchClass> nodes
Last modified: 2013-07-30 08:39:43 UTC
We never ever set search classes anywhere, see https://git.gnome.org/browse/rygel/tree/src/plugins/media-export/rygel-media-export-db-container.vala#n41
Created attachment 247846 [details] [review] Patch for fixing search class for containers
Review of attachment 247846 [details] [review]: ::: src/librygel-server/rygel-media-container.vala @@ -294,3 +294,4 @@ } - if (this.parent == null && (this is SearchableContainer)) { + // If the container is searchable then it must add search class parameters. + if (this is SearchableContainer) { Well not strictly necessary for 7.3.67.4 but probably good for consistentcy ::: src/plugins/media-export/rygel-media-export-db-container.vala @@ +40,3 @@ this.media_db = MediaCache.get_default (); this.search_classes = new ArrayList<string> (); + this.search_classes.add (Rygel.VideoItem.UPNP_CLASS); That's not enough, please also add the other item types
Created attachment 250386 [details] [review] Patch for fixing search class for containers
@Jens: Updated the patch as per review.
Pushed with minor rewording of commit message (initial line too long)