After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702254 - 7.3.67.4: MediaExport does not provide <upnp:searchClass> nodes
7.3.67.4: MediaExport does not provide <upnp:searchClass> nodes
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: MediaExport plugin
git master
Other Linux
: Normal normal
: ---
Assigned To: Jens Georg
rygel-maint
ivi
Depends on:
Blocks:
 
 
Reported: 2013-06-14 11:37 UTC by Jens Georg
Modified: 2013-07-30 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for fixing search class for containers (1.88 KB, patch)
2013-06-26 17:46 UTC, Parthiban Balasubramanian
needs-work Details | Review
Patch for fixing search class for containers (2.19 KB, patch)
2013-07-29 17:03 UTC, Parthiban Balasubramanian
committed Details | Review

Description Jens Georg 2013-06-14 11:37:32 UTC
We never ever set search classes anywhere, see https://git.gnome.org/browse/rygel/tree/src/plugins/media-export/rygel-media-export-db-container.vala#n41
Comment 1 Parthiban Balasubramanian 2013-06-26 17:46:28 UTC
Created attachment 247846 [details] [review]
Patch for fixing search class for containers
Comment 2 Jens Georg 2013-06-27 10:51:19 UTC
Review of attachment 247846 [details] [review]:

::: src/librygel-server/rygel-media-container.vala
@@ -294,3 +294,4 @@
         }
 
-        if (this.parent == null && (this is SearchableContainer)) {
+        // If the container is searchable then it must add search class parameters.
+        if (this is SearchableContainer) {

Well not strictly necessary for 7.3.67.4 but probably good for consistentcy

::: src/plugins/media-export/rygel-media-export-db-container.vala
@@ +40,3 @@
         this.media_db = MediaCache.get_default ();
         this.search_classes = new ArrayList<string> ();
+        this.search_classes.add (Rygel.VideoItem.UPNP_CLASS);

That's not enough, please also add the other item types
Comment 3 Parthiban Balasubramanian 2013-07-29 17:03:54 UTC
Created attachment 250386 [details] [review]
Patch for fixing search class for containers
Comment 4 Parthiban Balasubramanian 2013-07-29 17:04:11 UTC
@Jens: Updated the patch as per review.
Comment 5 Jens Georg 2013-07-30 08:38:36 UTC
Pushed with minor rewording of commit message (initial line too long)