GNOME Bugzilla – Bug 702171
Implement Shuffle
Last modified: 2013-06-21 17:21:41 UTC
.
Created attachment 246724 [details] [review] Rename shuffle key of settings schema as repeat This will update the settings schema to add other repeat types other than shuffle.
Comment on attachment 246724 [details] [review] Rename shuffle key of settings schema as repeat The following fix has been pushed: 8841e44 Rename "shuffle" key of settings schema as "repeat"
Created attachment 246731 [details] [review] Rename "shuffle" key of settings schema as "repeat" Add a new enum to the settings schema that matches Player.RepeatType and rename the "shuffle" key as "repeat".
Created attachment 247026 [details] [review] gsettings to store the repeat stype
Created attachment 247032 [details] [review] gsettings to store the repeat stype Removes whitespace errors and other such fixes.
Review of attachment 247032 [details] [review]: Breaks tests: Running suite tests_albumPlayback.js Gjs-Message: JS LOG: running test testAlbumViewPlayback Gtk-Message: Failed to load module "pk-gtk-module" Gtk-Message: Failed to load module "canberra-gtk-module" (gjs:1819): Gjs-WARNING **: JS ERROR: TypeError: Application.settings is null Player<._setupView@../src/player.js:348 wrapper@/opt/gnome/share/gjs-1.0/lang.js:213 Player<._init@../src/player.js:117 wrapper@/opt/gnome/share/gjs-1.0/lang.js:213 _Base._construct@/opt/gnome/share/gjs-1.0/lang.js:154 Class._construct/newClass@/opt/gnome/share/gjs-1.0/lang.js:248 getAlbumView@tests_albumPlayback.js:37 testAlbumViewPlayback@tests_albumPlayback.js:50 gjstestRun@/opt/gnome/share/gjs-1.0/jsUnit.js:438 gjstestRun@tests_albumPlayback.js:4 @tests_albumPlayback.js:167
Applied gcampax's patches and implemented shuffle in 7b42067