After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702164 - Convert to GtkListBox
Convert to GtkListBox
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-13 10:23 UTC by Alexander Larsson
Modified: 2013-07-02 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require Gtk 3.9.1 for GtkListBox (737 bytes, patch)
2013-06-13 10:23 UTC, Alexander Larsson 		committed Details | Review
language-chooser: Convert to GtkListBox (15.72 KB, patch)
2013-06-13 10:23 UTC, Alexander Larsson 		committed Details | Review
color panel: Convert to GtkListBox (15.42 KB, patch)
2013-06-13 10:23 UTC, Alexander Larsson 		committed Details | Review
notifications: Convert to GtkListBox (5.63 KB, patch)
2013-06-13 10:23 UTC, Alexander Larsson 		committed Details | Review
power: Convert to GtkListBox (19.81 KB, patch)
2013-06-13 10:23 UTC, Alexander Larsson 		committed Details | Review
privacy: Convert to GtkListBox (4.17 KB, patch)
2013-06-13 10:23 UTC, Alexander Larsson 		committed Details | Review
region: Convert to GtkListBox (70.99 KB, patch)
2013-06-13 10:24 UTC, Alexander Larsson 		committed Details | Review
search: Convert to GtkListBox (15.60 KB, patch)
2013-06-13 10:24 UTC, Alexander Larsson 		committed Details | Review
sharing: Convert to GtkListBox (8.17 KB, patch)
2013-06-13 10:24 UTC, Alexander Larsson 		committed Details | Review
online-accounts: Convert to GtkListBox (7.22 KB, patch)
2013-06-13 10:24 UTC, Alexander Larsson 		committed Details | Review
network: Convert to GtkListBox (10.56 KB, patch)
2013-06-13 10:24 UTC, Alexander Larsson 		committed Details | Review
network: Convert connection editor to GtkListBox (41.31 KB, patch)
2013-06-23 02:33 UTC, Kalev Lember 		committed Details | Review
main: Drop the use of EggListBox (913 bytes, patch)
2013-06-23 02:34 UTC, Kalev Lember 		committed Details | Review
build: Drop EggListBox (3.41 KB, patch)
2013-06-23 02:34 UTC, Kalev Lember 		none Details | Review
build: Drop EggListBox (4.09 KB, patch)
2013-07-02 14:46 UTC, Kalev Lember 		committed Details | Review

Description Alexander Larsson 2013-06-13 10:23:16 UTC 
Now that its landed we should stop using EggListBox.
Comment 1 Alexander Larsson 2013-06-13 10:23:40 UTC 
Created attachment 246701 [details] [review]
Require Gtk 3.9.1 for GtkListBox
Comment 2 Alexander Larsson 2013-06-13 10:23:44 UTC 
Created attachment 246702 [details] [review]
language-chooser: Convert to GtkListBox
Comment 3 Alexander Larsson 2013-06-13 10:23:48 UTC 
Created attachment 246703 [details] [review]
color panel: Convert to GtkListBox
Comment 4 Alexander Larsson 2013-06-13 10:23:51 UTC 
Created attachment 246704 [details] [review]
notifications: Convert to GtkListBox
Comment 5 Alexander Larsson 2013-06-13 10:23:55 UTC 
Created attachment 246705 [details] [review]
power: Convert to GtkListBox
Comment 6 Alexander Larsson 2013-06-13 10:23:59 UTC 
Created attachment 246706 [details] [review]
privacy: Convert to GtkListBox
Comment 7 Alexander Larsson 2013-06-13 10:24:03 UTC 
Created attachment 246707 [details] [review]
region: Convert to GtkListBox
Comment 8 Alexander Larsson 2013-06-13 10:24:07 UTC 
Created attachment 246708 [details] [review]
search: Convert to GtkListBox
Comment 9 Alexander Larsson 2013-06-13 10:24:11 UTC 
Created attachment 246709 [details] [review]
sharing: Convert to GtkListBox
Comment 10 Alexander Larsson 2013-06-13 10:24:16 UTC 
Created attachment 246710 [details] [review]
online-accounts: Convert to GtkListBox
Comment 11 Alexander Larsson 2013-06-13 10:24:20 UTC 
Created attachment 246711 [details] [review]
network: Convert to GtkListBox
Comment 12 Kalev Lember 2013-06-23 02:33:16 UTC 
Attaching three more patches that complete the port.
Comment 13 Kalev Lember 2013-06-23 02:33:57 UTC 
Created attachment 247545 [details] [review]
network: Convert connection editor to GtkListBox
Comment 14 Kalev Lember 2013-06-23 02:34:16 UTC 
Created attachment 247546 [details] [review]
main: Drop the use of EggListBox

Now that all panels have been ported, we no longer need to do
g_type_ensure.
Comment 15 Kalev Lember 2013-06-23 02:34:26 UTC 
Created attachment 247547 [details] [review]
build: Drop EggListBox
Comment 16 Kalev Lember 2013-07-02 14:46:49 UTC 
Created attachment 248232 [details] [review]
build: Drop EggListBox
Comment 17 Thomas Wood 2013-07-02 15:33:48 UTC 
Patches rebased on master and pushed with a few updates to the power, region,
and sharing panel patches.

Attachment 246701 [details] pushed as c492349 - Require Gtk 3.9.1 for GtkListBox
Attachment 246702 [details] pushed as a07825a - language-chooser: Convert to GtkListBox
Attachment 246703 [details] pushed as 3a811de - color panel: Convert to GtkListBox
Attachment 246704 [details] pushed as 41b04d5 - notifications: Convert to GtkListBox
Attachment 246705 [details] pushed as 7a07b22 - power: Convert to GtkListBox
Attachment 246706 [details] pushed as eac949b - privacy: Convert to GtkListBox
Attachment 246707 [details] pushed as 1db26b4 - region: Convert to GtkListBox
Attachment 246708 [details] pushed as a46a652 - search: Convert to GtkListBox
Attachment 246709 [details] pushed as c0abad9 - sharing: Convert to GtkListBox
Attachment 246710 [details] pushed as 0f77c51 - online-accounts: Convert to GtkListBox
Attachment 246711 [details] pushed as b0356fd - network: Convert to GtkListBox
Attachment 247545 [details] pushed as 62f18a2 - network: Convert connection editor to GtkListBox
Attachment 247546 [details] pushed as a14e52b - main: Drop the use of EggListBox
Attachment 248232 [details] pushed as 620bc4b - build: Drop EggListBox