GNOME Bugzilla – Bug 702153
Missing and/or broken translations in the openconnect configuration dialog
Last modified: 2013-06-24 16:19:51 UTC
Created attachment 246691 [details] broken strings in the translation The German translation of the openconnect network manager contains both unprintable characters, and is incomplete as it contains a couple of elements that cannot be rendered. Please see the attached screen shot.
Hm, there is strangeness here. The translation appears to be correct: [dwmw2@shinybook po]$ grep 'Ge_heimer Schlüssel' de.po msgstr "Ge_heimer Schlüssel:" [dwmw2@shinybook po]$ grep 'Ge_heimer Schlüssel' de.po | hexdump -C 00000000 6d 73 67 73 74 72 20 22 47 65 5f 68 65 69 6d 65 |msgstr "Ge_heime| 00000010 72 20 53 63 68 6c c3 bc 73 73 65 6c 3a 22 0a |r Schl..ssel:".| 0000001f you are also missing strings for the "»Cisco Secure Desktop«-_Trojaner erlauben" and "_FSID für Schlüsselkennwort verwenden" checkboxes. There's something going here that I don't understand, but I think it isn't just the translations being wrong.
Thomas, what is your distro and package version?
Distro is Debian wheezy, but with gnome from squeeze (I cannot stand gnome 3). Network-manager-openconnect is 0.9.4.0-8 (both the plugin and the UI).
It looks like we never bind_textdomain_codeset() on the vpn plugin translation domains, so if you're running in a non-UTF-8 locale, bad things happen.
Thanks for spotting this. Yes indeed, this is a non-UTF system. Actually, it is ISO-Latin for legacy reasons.
Created attachment 246732 [details] [review] properties: call bindtextdomain() and bind_textdomain_codeset() Make sure gettext knows the translations are in UTF-8, or else they'll get garbled if the user's domain isn't UTF-8. ===== This is the patch for openconnect, the other VPN plugin patches are basically identical (except for slight Makefile differences)
Thanks. Should I leave you to commit this?
done