After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702097 - keyboard: Gain permission and set X11Keyboard (system) on localed
keyboard: Gain permission and set X11Keyboard (system) on localed
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-12 14:22 UTC by Michael Wood
Modified: 2013-06-12 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Gain permission and set X11Keyboard (system) on localed (4.73 KB, patch)
2013-06-12 14:22 UTC, Michael Wood 		none Details | Review
keyboard: Gain permission and set X11Keyboard (system) on localed (5.07 KB, patch)
2013-06-12 14:28 UTC, Michael Wood 		none Details | Review
keyboard: Make sure we call set_localed_input to set system input source (804 bytes, patch)
2013-06-12 16:28 UTC, Michael Wood 		accepted-commit_now Details | Review
keyboard: Request permission to update system input source (5.07 KB, patch)
2013-06-12 16:29 UTC, Michael Wood 		accepted-commit_now Details | Review

Description Michael Wood 2013-06-12 14:22:57 UTC 
Previously we weren't actually calling set on the X11Keyboard nor did we
request permission. This fixes that.
Comment 1 Michael Wood 2013-06-12 14:22:59 UTC 
Created attachment 246645 [details] [review]
keyboard: Gain permission and set X11Keyboard (system) on localed
Comment 2 Michael Wood 2013-06-12 14:28:55 UTC 
Created attachment 246647 [details] [review]
keyboard: Gain permission and set X11Keyboard (system) on localed

Previously we weren't actually calling set on the X11Keyboard nor did we
request permission. This fixes that.
Comment 3 Michael Wood 2013-06-12 16:28:57 UTC 
Created attachment 246655 [details] [review]
keyboard: Make sure we call set_localed_input to set system input source
Comment 4 Michael Wood 2013-06-12 16:29:40 UTC 
Created attachment 246656 [details] [review]
keyboard: Request permission to update system input source

(Patches split as requested)
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-06-12 16:30:56 UTC 
Review of attachment 246655 [details] [review]:

OK.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-06-12 16:31:07 UTC 
Review of attachment 246656 [details] [review]:

OK.
Comment 7 Michael Wood 2013-06-12 20:15:22 UTC 
keyboard: Make sure we call set_localed_input to set system input source 55542ed6f39fcd89e7fa35e11e420ab82b30a114 


keyboard: Request permission to update system input source 37ba310741a462988f3a706e175c2ae9a7ddeecc