After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702084 - rtsp-media: UTC ranges in RTSP PLAY response
rtsp-media: UTC ranges in RTSP PLAY response
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-12 11:28 UTC by David Svensson Fors
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media: convert_range replaces get_range_times (5.54 KB, patch)
2013-06-12 11:28 UTC, David Svensson Fors 		none Details | Review

Description David Svensson Fors 2013-06-12 11:28:17 UTC 
Created attachment 246611 [details] [review]
media: convert_range replaces get_range_times

My patch for Bug #701191 didn't handle RTSP UTC ranges completely. get_range_times() worked for handling UTC ranges for seeks, but we also need to convert back from NPT to the requested unit in gst_rtsp_media_get_range_string(), for the PLAY response.

In the attached suggested patch, get_range_times() is replaced by convert_range(), which is overridable and used for converting both ways. Problems with UTC are avoided by converting to NPT before seeks.
Comment 1 Wim Taymans 2013-06-14 14:12:05 UTC 
commit 6151072a2ebc35988c25e0c88af563c0bab40e90
Author: David Svensson Fors <davidsf@axis.com>
Date:   Wed Jun 5 15:49:45 2013 +0200

    media: convert_range replaces get_range_times
    
    get_range_times worked for handling UTC ranges for seeks, but we also
    need to convert back from NPT to the requested unit in
    get_range_string. convert_range is now used for both.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=702084