After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702059 - Use a headerbar
Use a headerbar
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-12 03:49 UTC by Matthias Clasen
Modified: 2014-02-25 04:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use a headerbar (5.64 KB, patch)
2013-06-12 03:49 UTC, Matthias Clasen 		reviewed Details | Review

Description Matthias Clasen 2013-06-12 03:49:18 UTC 
This brings the layout much closer to the design.
Comment 1 Matthias Clasen 2013-06-12 03:49:20 UTC 
Created attachment 246588 [details] [review]
Use a headerbar
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-06-12 04:01:34 UTC 
Review of attachment 246588 [details] [review]:

::: gnome-initial-setup/gis-assistant.c
@@ +472,3 @@
   gtk_widget_show (widget);
 
+  gtk_header_bar_pack_start (GTK_HEADER_BAR (priv->titlebar), priv->cancel);

Can't "navigation" and the GisCenterContainer be removed now?

::: gnome-initial-setup/gis-driver.c
@@ -100,3 @@
-{
-  GisDriverPrivate *priv = driver->priv;
-  gtk_window_set_title (priv->main_window, gis_assistant_get_title (assistant));

You should probably keep the window title setting as well so it shows up nicely in the overview and alt-tab.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-06-16 04:00:40 UTC 
The other thing I didn't think about is whether Intel can use this, because it looks like they're staying with GTK+ 3.8.
Comment 4 Michael Wood 2013-06-17 14:37:18 UTC 
Yeah, we wouldn't want this I'm afraid, could you stick it in a branch? or make a 3.8 branch?
Comment 5 Matthias Clasen 2013-06-17 17:24:27 UTC 
given that we are staying with 3.8 as well, a branch might indeed be advised
Comment 6 Matthias Clasen 2014-02-25 04:51:18 UTC 
we do use a headerbar now