After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702052 - Update get_commits_to_push_summary to raise NotImplementedError on _vc base
Update get_commits_to_push_summary to raise NotImplementedError on _vc base
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: filediff
unspecified
Other All
: Normal normal
: ---
Assigned To: meld-maint
meld-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-12 02:14 UTC by Louis
Modified: 2013-06-16 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update get_commits_to_push_summary to raise NotImplementedError on _vc base (1.33 KB, patch)
2013-06-12 02:14 UTC, Louis 		none Details | Review

Description Louis 2013-06-12 02:14:42 UTC 
Instead of catching an AttributeError which seems ugly.
Comment 1 Louis 2013-06-12 02:14:44 UTC 
Created attachment 246575 [details] [review]
Update get_commits_to_push_summary to raise NotImplementedError on _vc base
Comment 2 Kai Willadsen 2013-06-14 21:15:06 UTC 
Just a minor comment... I like to keep git commit messages to the standard format, which mostly just means 72 characters wide and a blank line after the one-line title. (I've fixed this in this commit, so don't worry about it here.)

Also, when a commit fixes a specific bug, I usually use the (bgo#<bug number>) suffix on commits. I don't know if any other project in existence adopted this idea though, so I'm not fussed about that. As long as there is a bugzilla reference in the commit message (which you always have) then we're good.

Anyway, pushed. Cheers.
Comment 3 Louis 2013-06-16 13:05:58 UTC 
The bugzilla reference in the commit is coming from git-bz which appends it automatically and uploads to create a new bug.

Will make the commit messages cleaner in future =)