After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701969 - Transition display->collection broken against clutter 1.16
Transition display->collection broken against clutter 1.16
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: display
3.9
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-11 00:57 UTC by Zeeshan Ali
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screencast of the issue (126.51 KB, video/webm)
2013-06-11 00:57 UTC, Zeeshan Ali 		  Details
app: Use explicit transition for display->collection (3.98 KB, patch)
2013-06-11 01:00 UTC, Zeeshan Ali 		none Details | Review
app: Use explicit transition for display->collection (4.54 KB, patch)
2013-06-13 14:50 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2013-06-11 00:57:14 UTC 
Created attachment 246467 [details]
Screencast of the issue

When going back from display to collection view, the display actor remains visible on top of the item icon.
Comment 1 Zeeshan Ali 2013-06-11 01:00:29 UTC 
Created attachment 246468 [details] [review]
app: Use explicit transition for display->collection
Comment 2 Zeeshan Ali 2013-06-11 01:06:27 UTC 
(In reply to comment #1)
> Created an attachment (id=246468) [details] [review]
> app: Use explicit transition for display->collection

This WIP patch fixes this issue at hand but the animation doesn't seem quite right. I'm not exactly sure that I actually understand how position_item_actor_at_icon() works. It sets the duration to '0' before setting the position props (animatable) and width/height (not animatable) so all these changes should be immediate? Is so, where is the animation coming into play?
Comment 3 Zeeshan Ali 2013-06-13 14:50:16 UTC 
Created attachment 246730 [details] [review]
app: Use explicit transition for display->collection

This fixes the issue of display actor ending-up at the top of item in
collection view at the end of display->collection animation when linked
against clutter 0.16.
Comment 4 Marc-Andre Lureau 2013-06-13 15:50:38 UTC 
Review of attachment 246730 [details] [review]:

not really happy about the change, but well, clutter is making our life unnecessarily harder...

Is this compatible with 0.14? If not we should bump dep.
Comment 5 Zeeshan Ali 2013-06-13 21:28:37 UTC 
(In reply to comment #4)
> Review of attachment 246730 [details] [review]:
> 
> not really happy about the change, but well, clutter is making our life
> unnecessarily harder...
> 
> Is this compatible with 0.14? If not we should bump dep.

Yes, its compatible AFAICT. We are already using the same explicit transition API in git master and all of this was added in 1.10 and 1.12. Sorry for the wrong version btw. Its 1.16, not 0.16. Will update commit log during push.
Comment 6 Zeeshan Ali 2013-06-14 15:12:35 UTC 
Attachment 246730 [details] pushed as 2f4b859 - app: Use explicit transition for display->collection