After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701929 - cc_shell_set_active_panel(shell, NULL) does not return to overview
cc_shell_set_active_panel(shell, NULL) does not return to overview
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-10 13:00 UTC by Xavier Claessens
Modified: 2013-06-14 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Go back to overview When setting panel to NULL (852 bytes, patch)
2013-06-10 13:02 UTC, Xavier Claessens 		accepted-commit_now Details | Review

Description Xavier Claessens 2013-06-10 13:00:24 UTC 
cc_shell_set_active_panel()'s do says:
"""
If @panel is NULL, then the shell is returned to a state where no panel is being displayed (for example, the list of panels may be shown instead).
"""

But implementation in cc-window.c::set_active_panel() doesn't do that.
Comment 1 Xavier Claessens 2013-06-10 13:02:27 UTC 
Created attachment 246401 [details] [review]
Go back to overview When setting panel to NULL

This is what cc_shell_set_active_panel()'s doc says it
it supposed to do.
Comment 2 Bastien Nocera 2013-06-11 15:36:14 UTC 
Review of attachment 246401 [details] [review]:

> Go back to overview When setting panel to NULL

Prepend "shell: " to the subject line.

> This is what cc_shell_set_active_panel()'s doc says it
> it supposed to do.

"it it". Otherwise looks good, thanks!
Comment 3 Xavier Claessens 2013-06-14 09:52:54 UTC 
Thanks, fixed and merged to both master and 3.8.