After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701898 - Missing type fixes for g_atomic_int_get g_atomic_pointer_get in gatomic.c
Missing type fixes for g_atomic_int_get g_atomic_pointer_get in gatomic.c
Status: RESOLVED DUPLICATE of bug 697386
Product: glib
Classification: Platform
Component: build
2.36.x
Other Solaris
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-06-09 14:10 UTC by Peter Tribble
Modified: 2015-08-27 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add const to gatomic.c where necessary. (751 bytes, patch)
2013-06-09 14:10 UTC, Peter Tribble 		none Details | Review

Description Peter Tribble 2013-06-09 14:10:38 UTC 
Created attachment 246351 [details] [review]
Add const to gatomic.c where necessary.

After manually working around 701897, I then discover that some but not all instances of g_atomic_int_get and g_atomic_pointer_get in blib/gatomic.c have been updated to use const. This manifests itself as:

  CC       libglib_2_0_la-gatomic.lo
gatomic.c:686: error: conflicting types for 'g_atomic_int_get'
gatomic.h:34: error: previous declaration of 'g_atomic_int_get' was here
gatomic.c:686: error: conflicting types for 'g_atomic_int_get'
gatomic.h:34: error: previous declaration of 'g_atomic_int_get' was here
gatomic.c:801: error: conflicting types for 'g_atomic_pointer_get'
gatomic.h:60: error: previous declaration of 'g_atomic_pointer_get' was here
gatomic.c:801: error: conflicting types for 'g_atomic_pointer_get'
gatomic.h:60: error: previous declaration of 'g_atomic_pointer_get' was here

The fix is simple; add const in the two places it's missing, see attached patch.
Comment 1 Nirbheek Chauhan 2015-08-27 15:14:09 UTC 
This is a duplicate of bug 697386, which is fixed. Please close.
Comment 2 Michael Catanzaro 2015-08-27 16:09:07 UTC 

*** This bug has been marked as a duplicate of bug 697386 ***