After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701858 - gnome-clocks: suggestion: Make headerbar a titlebar. Convert Window to a Template.
gnome-clocks: suggestion: Make headerbar a titlebar. Convert Window to a Temp...
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-08 16:17 UTC by Evgeny Bobkin
Modified: 2013-06-09 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch proposal: Make headerbar a titlebar. Convert Window to a Template. (7.84 KB, patch)
2013-06-08 16:21 UTC, Evgeny Bobkin 		none Details | Review
a patch proposal: Make headerbar a titlebar. Convert Window to a Template. (7.84 KB, patch)
2013-06-09 15:13 UTC, Evgeny Bobkin 		none Details | Review
a patch proposal: Make headerbar a titlebar. Convert Window to a Template. (6.99 KB, patch)
2013-06-09 19:06 UTC, Evgeny Bobkin 		none Details | Review

Description Evgeny Bobkin 2013-06-08 16:17:36 UTC 
Improvements: Make headerbar a titlebar. Convert Window to a Template.
Comment 1 Evgeny Bobkin 2013-06-08 16:21:10 UTC 
Created attachment 246312 [details] [review]
a patch proposal: Make headerbar a titlebar. Convert Window to a Template.
Comment 2 Paolo Borelli 2013-06-09 09:54:43 UTC 
Review of attachment 246312 [details] [review]:

The patch looks good, as discussed in the chat we can try to refactor the close button in the header class later, but I think we can start committing this.

Just a couple of comments below.

::: data/ui/window.ui
@@ -18,3 +12,3 @@
     </child>
     <child>
-      <object class="GtkFrame" id="frame1">
+      <object class="GtkGrid" id="main_panel">

why do we need an extra grid around the frame?

::: src/window.vala
@@ -74,0 +72,11 @@
+        separator = new Gtk.Separator (Gtk.Orientation.VERTICAL);
+        separator.no_show_all = true;
+        separator.valign = Gtk.Align.FILL;
... 8 more ...

nitpick: I do not think we leave a space before () in the other parts of the code
Comment 3 Evgeny Bobkin 2013-06-09 11:19:48 UTC 
(In reply to comment #2)
> Review of attachment 246312 [details] [review]:
> 
> The patch looks good, as discussed in the chat we can try to refactor the close
> button in the header class later, but I think we can start committing this.
> 
> Just a couple of comments below.
> 
> ::: data/ui/window.ui
> @@ -18,3 +12,3 @@
>      </child>
>      <child>
> -      <object class="GtkFrame" id="frame1">
> +      <object class="GtkGrid" id="main_panel">
> 
> why do we need an extra grid around the frame?
> 
no, we do not need it at all)
> ::: src/window.vala
> @@ -74,0 +72,11 @@
> +        separator = new Gtk.Separator (Gtk.Orientation.VERTICAL);
> +        separator.no_show_all = true;
> +        separator.valign = Gtk.Align.FILL;
> ... 8 more ...
> 
> nitpick: I do not think we leave a space before () in the other parts of the
> code
thanks, this is a tipo.
Comment 4 Evgeny Bobkin 2013-06-09 15:13:12 UTC 
Created attachment 246358 [details] [review]
 a patch proposal: Make headerbar a titlebar. Convert Window to a Template.
Comment 5 Evgeny Bobkin 2013-06-09 19:06:54 UTC 
Created attachment 246365 [details] [review]
a patch proposal: Make headerbar a titlebar. Convert Window to a Template.
Comment 6 Paolo Borelli 2013-06-09 20:52:13 UTC 
pushed