GNOME Bugzilla – Bug 701850
folks-DEBUG: phone-details.vala:160: [PhoneDetails.get_normalised] unknown digit: +
Last modified: 2013-08-02 08:05:56 UTC
Hi, When running gnome-contacts with the folks debug messages enabled, I'm getting a log of messages similar to this: (gnome-contacts:23221): folks-DEBUG: phone-details.vala:108: [PhoneDetails.equal] Comparing 8474136 with 8474136 (gnome-contacts:23221): folks-DEBUG: phone-details.vala:160: [PhoneDetails.get_normalised] unknown digit: + (gnome-contacts:23221): folks-DEBUG: phone-details.vala:160: [PhoneDetails.get_normalised] unknown digit: + This is probably due to the fact that my contacts have their phone numbers in the international format (+CCXXXXX)
Created attachment 246977 [details] [review] Keep leading ‘+’s when normalising phone numbers https://www.gitorious.org/folks/folks/commits/701850-phone-country-codes Looks like the fix for bug #685992 was incomplete. The attached patch fixes it and adds a test case.
Review of attachment 246977 [details] [review]: ++
Comment on attachment 246977 [details] [review] Keep leading ‘+’s when normalising phone numbers commit e1da1db6af2930e9ed5045d3abb0c73c4f74d26e Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sun Jun 16 20:23:17 2013 +0100 core: Keep leading ‘+’s when normalising phone numbers These are needed to indicate country codes for international numbers. See: https://bugzilla.gnome.org/show_bug.cgi?id=685992 Closes: https://bugzilla.gnome.org/show_bug.cgi?id=701850 NEWS | 2 ++ folks/phone-details.vala | 5 +++-- tests/folks/Makefile.am | 5 +++++ tests/folks/phone-field-details.vala | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 76 insertions(+), 2 deletions(-)