After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701844 - scores not sorted
scores not sorted
Status: RESOLVED FIXED
Product: gnome-mahjongg
Classification: Applications
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-mahjongg-maint
gnome-mahjongg-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-08 13:21 UTC by generalsnus
Modified: 2013-11-03 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
top ten scores not sorting by duration (188.21 KB, image/png)
2013-06-08 13:21 UTC, generalsnus 		  Details
Sort scores by duration of the game (888 bytes, patch)
2013-11-03 14:34 UTC, Michael Catanzaro 		committed Details | Review

Description generalsnus 2013-06-08 13:21:40 UTC 
Created attachment 246302 [details]
top ten scores not sorting by duration

Should be top 10 game duration in ascending order, not all game dates in order of date played.

I'm using Arch linux with latest 3.8 available from their repositories.

Steps to reproduce- play more than 10 games, check scores and every game that has been played displays and they are not sorted in ascending order of game duration.
Comment 1 Michael Catanzaro 2013-11-02 23:40:25 UTC 
Some other games ought to be limited to the top 10 as well.  (Mines at least is also affected.)
Comment 2 Michael Catanzaro 2013-11-03 14:30:46 UTC 
(In reply to comment #1)
> Some other games ought to be limited to the top 10 as well.  (Mines at least is
> also affected.)
Sorry, my last comment was incorrect.  We intentionally display the entire history, and request a 200x300 window to display the scores in. Did you resize it manually?
Comment 3 Michael Catanzaro 2013-11-03 14:34:43 UTC 
The following fix has been pushed:
4ba2964 Sort scores by duration of the game
Comment 4 Michael Catanzaro 2013-11-03 14:34:46 UTC 
Created attachment 258852 [details] [review]
Sort scores by duration of the game

i.e. display the highest scores first. The date should be used as a
tiebreaker, not the primary factor.