After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701838 - Work around a semantic API break in GObject
Work around a semantic API break in GObject
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 701804 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-06-08 09:53 UTC by Tristan Van Berkom
Modified: 2013-09-21 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move property installation and various class initialization details to subclass_class_init() (5.83 KB, patch)
2013-06-08 09:53 UTC, Tristan Van Berkom
committed Details | Review

Description Tristan Van Berkom 2013-06-08 09:53:02 UTC
Created attachment 246298 [details] [review]
Move property installation and various class initialization details to subclass_class_init()

Now GObject fires critical assertions if g_object_class_install_property() is
called outside of a class initializer.

Critical warnings cause test cases to abort, currently all of our test
cases fail because e_source_camel_generate_subtype() installs properties
on generated types after the class initializer finishes.

Attached patch moves the related class initialization code into the
class initializer.
Comment 1 Matthew Barnes 2013-06-08 14:02:11 UTC
*** Bug 701804 has been marked as a duplicate of this bug. ***
Comment 2 Matthew Barnes 2013-06-08 14:24:28 UTC
Man, the things we get away with without calling an API break an API break...

Thanks much for the patch.  Glad someone else out there understands this crazy glue code I had to write for Camel.

Committed for E-D-S 3.9.3 and 3.8.3:

https://git.gnome.org/browse/evolution-data-server/commit/?id=069ca4ff6b62d7c4a04c6e23db218c585b13778f

https://git.gnome.org/browse/evolution-data-server/commit/?h=gnome-3-8&id=32a40cabc8f0cb00702dfeebbdb762d5a28e5789