After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701793 - something broken in vapi-land
something broken in vapi-land
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: API
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-07 14:52 UTC by Dan Winship
Modified: 2014-01-13 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Dan Winship 2013-06-07 14:52:29 UTC 
lately I get lots of:

danw@laptop:vapi (master)> make
 VAPIGEN libnm-glib.vapi

** (vapigen-0.18:9015): CRITICAL **: vala_code_node_get_attribute_string: assertion `self != NULL' failed

** (vapigen-0.18:9015): CRITICAL **: vala_code_node_get_attribute_string: assertion `self != NULL' failed

** (vapigen-0.18:9015): CRITICAL **: vala_code_node_get_attribute_string: assertion `self != NULL' failed
...

and then it exits claiming success, but then if I type "make" again, it tries again, and prints the same warnings again.


bisect blames:

commit c41bd34570f1d7c9022ef2617eee7b4ae1d757a2
Author: Dan Williams <dcbw@redhat.com>
Date:   Fri Apr 19 18:44:13 2013 -0500

    libnm-glib: add support for new connection unsaved functionality


and gdb'ing through vapigen suggests that it has something to do with this:

+/* Backwards compatibility */
+typedef NMRemoteConnectionResultFunc NMRemoteConnectionCommitFunc;
+typedef NMRemoteConnectionResultFunc NMRemoteConnectionDeleteFunc;

but I don't know how to fix it
Comment 1 Dan Winship 2014-01-02 21:07:48 UTC 
vala bug is bug 667751
Comment 2 Luca Bruno 2014-01-02 21:56:24 UTC 
Can you make V=1?
Comment 3 Dan Winship 2014-01-02 22:14:53 UTC 
danw@laptop:vapi (master)> make V=1
/usr/bin/vapigen-0.22  --library libnm-util --metadatadir .    ../libnm-util/NetworkManager-1.0.gir
Generation succeeded - 0 warning(s)
/usr/bin/vapigen-0.22  --library libnm-glib --metadatadir . --vapidir . --girdir ../libnm-util --pkg gio-2.0 ../libnm-glib/NMClient-1.0.gir

** (vapigen-0.22:26745): CRITICAL **: vala_code_node_get_attribute_string: assertion 'self != NULL' failed

...

** (vapigen-0.22:26745): CRITICAL **: vala_gir_parser_add_symbol_to_container: assertion 'sym != NULL' failed
Generation succeeded - 0 warning(s)
Comment 4 Luca Bruno 2014-01-02 22:18:29 UTC 
Thanks, will look into it asap. Must be something tricky with those typedefs to callbacks :(
Comment 5 Dan Winship 2014-01-13 14:17:42 UTC 
This is now fixed in vala in git.