After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701781 - Ctrl + Q should quit all opened instances of Gitg
Ctrl + Q should quit all opened instances of Gitg
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-07 11:28 UTC by Sindhu S
Modified: 2014-07-10 18:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sindhu S 2013-06-07 11:28:33 UTC
Currently only Ctrl + W seems to work on a single gitg window, Ctrl + Q is not working.
Comment 1 Sindhu S 2013-06-08 18:30:08 UTC
The behaviour is Ctrl + Q works in GNOME Shell, however isn't so in awesome wm.
Comment 2 Sindhu S 2013-06-12 05:46:13 UTC
Ctrl + Q only closes current gitg window even in GNOME Shell
Comment 3 Sindhu S 2013-09-02 13:05:36 UTC
Checked with gitg running from git master today, Ctrl + Q indeed closes all windows of Gitg but not in all situations.

Case 1:
I opened gitg windows like this:

➜  libgit2-glib git:(master) jhbuild run gitg
Gtk-Message: Failed to load module "canberra-gtk-module"

➜  gitg git:(master) jhbuild run gitg
Gtk-Message: Failed to load module "canberra-gtk-module"


When I pressed Ctrl + Q, both windows closed.

Case 2:

➜  gitg git:(master) jhbuild run gitg
Gtk-Message: Failed to load module "canberra-gtk-module"

Press Ctrl + N and start a new instance of Gitg.

Here, pressing Ctrl + Q when new instance of Gitg is focussed, results in *only* the new instance closing.

Pressing Ctrl + Q when old instance is focussed, results in results in *only* old instance being closed.

Whereas the correct behaviour would be that *all* windows of Gitg are closed.
Comment 4 jessevdk@gmail.com 2014-07-10 10:24:29 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 5 jessevdk@gmail.com 2014-07-10 10:26:34 UTC
Sorry, jumped to fast on this. There are still problems with Ctrl+Q not closing all windows, and sometimes hanging gitg.
Comment 6 jessevdk@gmail.com 2014-07-10 18:22:18 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.