After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701760 - Generalize support for shell's schema overrides
Generalize support for shell's schema overrides
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on: 701717
Blocks:
 
 
Reported: 2013-06-06 20:07 UTC by Florian Müllner
Modified: 2013-08-26 21:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Generalize support for shell's schema overrides (7.34 KB, patch)
2013-06-06 20:07 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2013-06-06 20:07:29 UTC
See patch and bug 701717 for the shell/extensions changes.
Comment 1 Florian Müllner 2013-06-06 20:07:31 UTC
Created attachment 246188 [details] [review]
Generalize support for shell's schema overrides

GNOME Shell overrides some settings to use different default values
than standalone mutter. With the introduction of classic mode, things
got a little more complicated, as some of the overrides were reverted
again by extensions - to support either mode, we needed to pick the
right schema for all affected settings.
The shell has now introduced mode-specific overrides, and classic mode
started to use that instead of extensions; this means we will now need
to adapt all settings that *both* normal and classic mode override.
However rather than adjusting the affected settings, the new approach
allows us to generalize the support for schema overrides depending on
the current mode - this should allow us to handle future changes to
overrides in either normal or classic mode automatically.
Comment 2 John Stowers 2013-06-07 09:07:39 UTC
Good to see this cleaned up.

Does it break old (<3.8) support?

In any case it probbably doesn't matter, I am going to change my policy of keeping master supporting a few different g-s versions and depend on more bleeding edge stuff. I need to use some of the new gtk features for the gsoc g-t-t design update / modernization anyway.

I'll do the branching stuff this weekend.
Comment 3 Florian Müllner 2013-06-07 10:01:51 UTC
(In reply to comment #2)
> Good to see this cleaned up.
> 
> Does it break old (<3.8) support?

To be honest, I'd like this in 3.8 if possible - it's more than a cleanup on the shell side, it addresses an annoying classic mode bug. But to answer your question: the patch should work with every shell version since we switched to GSettings (3.2?), with the exception of classic mode in 3.8.
Comment 4 John Stowers 2013-06-07 10:08:34 UTC
Ok, thanks for the clarification.

If you have tested this against 3.8 then please commit it to master.
Comment 5 Florian Müllner 2013-06-07 10:26:44 UTC
Thanks! I'll do so once the shell/extension patches land.
Comment 6 Florian Müllner 2013-06-07 23:22:52 UTC
Attachment 246188 [details] pushed as 559b222 - Generalize support for shell's schema overrides

(In reply to comment #4)
> If you have tested this against 3.8 then please commit it to master.

Thanks again!

I should add that by landing bug 701717, some of the options in the last Tweak Tool release stopped working in "classic" mode as provided by gnome-shell-extensions-3.8.3 (just released). So it would be great to get a corresponding release to get this fix out - sorry for that, I'm of course willing to help out if you want me to.
Comment 7 John Stowers 2013-06-08 18:34:16 UTC
(In reply to comment #6)
> Attachment 246188 [details] pushed as 559b222 - Generalize support for shell's schema
> overrides
> 
> (In reply to comment #4)
> > If you have tested this against 3.8 then please commit it to master.
> 
> Thanks again!
> 
> I should add that by landing bug 701717, some of the options in the last Tweak
> Tool release stopped working in "classic" mode as provided by
> gnome-shell-extensions-3.8.3 (just released). So it would be great to get a
> corresponding release to get this fix out - sorry for that, I'm of course
> willing to help out if you want me to.

Do you want a 3.8.x release from master?

If you need this before Sunday then you may make the release (I am AFK tonight)

Otherwise I will do it tomorrow (Sunday night)
Comment 8 Florian Müllner 2013-06-08 20:04:13 UTC
> If you need this before Sunday

We are talking about two switches in Tweak Tool that won't work as expected if you are running the very latest GNOME classic session - so no, it's not so urgent that it cannot wait until next week.
Comment 9 Amit Mendapara 2013-07-31 07:07:47 UTC
The fix has broken the gnome-tweak-tool under gnome-shell. At least on Arch linux, some entries are missing.

See: https://bugs.archlinux.org/task/36340
Comment 10 Amit Mendapara 2013-08-26 13:43:10 UTC
This commit has caused this problem: https://git.gnome.org/browse/gnome-tweak-tool/commit/?h=gnome-3-8&id=ad72f1c8701baecdc9838b9bc6ee76748f6fcbd1

Should I report a new bug?
Comment 11 John Stowers 2013-08-26 13:52:46 UTC
(In reply to comment #10)
> This commit has caused this problem:
> https://git.gnome.org/browse/gnome-tweak-tool/commit/?h=gnome-3-8&id=ad72f1c8701baecdc9838b9bc6ee76748f6fcbd1
> 
> Should I report a new bug?

sure, please copy relevant details from arch bz here.
Comment 12 Amit Mendapara 2013-08-26 21:22:53 UTC
Just reported as a new bug: #706834