GNOME Bugzilla – Bug 701755
Initial fixes for aggregate menu work
Last modified: 2013-06-06 19:33:15 UTC
These are all small code fixes. None of them change any behavior.
Created attachment 246177 [details] [review] userMenu: Move UserAvatarWidget into UserWidget
Created attachment 246178 [details] [review] userMenu: Use addSettingsAction
Created attachment 246179 [details] [review] popupMenu: Fix bubbling in the slider widget
Created attachment 246180 [details] [review] slider: Separate PopupSliderMenuItem into its own widget
Created attachment 246181 [details] [review] volume: Remove some unused variables
Created attachment 246182 [details] [review] network: Remove a dead signal This signal is unused.
Created attachment 246183 [details] [review] network: Reformat connection code This makes the code flow the same between removeConnection and checkConnection.
Review of attachment 246177 [details] [review]: I wonder why it was in UserMenu before.
Review of attachment 246178 [details] [review]: I thought you had a later patch that removed addSettingsAction (given that the design removes control panel launchers).
Review of attachment 246179 [details] [review]: Ok
Review of attachment 246180 [details] [review]: Yes
Review of attachment 246181 [details] [review]: Ok
Review of attachment 246182 [details] [review]: Yes.
Review of attachment 246183 [details] [review]: ::: js/ui/status/network.js @@ +1954,3 @@ + } else if (section == NMConnectionCategory.VPN) { + this._vpnSection.removeConnection(connection); + } else if (section != NMConnectionCategory.INVALID) { You check this condition above.
Review of attachment 246178 [details] [review]: We still use it in the accessibility and keyboard dropdowns, and the new design has submenus with launchers, so it's useful to keep it around. https://raw.github.com/gnome-design-team/gnome-mockups/master/shell/combined-system-status-menu-v2-submenus.png
Attachment 246177 [details] pushed as 403540e - userMenu: Move UserAvatarWidget into UserWidget Attachment 246178 [details] pushed as b68eb44 - userMenu: Use addSettingsAction Attachment 246179 [details] pushed as cc64091 - popupMenu: Fix bubbling in the slider widget Attachment 246180 [details] pushed as 847cb5b - slider: Separate PopupSliderMenuItem into its own widget Attachment 246181 [details] pushed as 23dd5cc - volume: Remove some unused variables Attachment 246182 [details] pushed as 380a71d - network: Remove a dead signal Attachment 246183 [details] pushed as aee7cd7 - network: Reformat connection code Pushed with fix for the last one. Nice catch!