After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701754 - [PATCH] Make GConf depency completely optional
[PATCH] Make GConf depency completely optional
Status: RESOLVED FIXED
Product: aisleriot
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: gnome-3-18
Assigned To: aisleriot-maint
aisleriot-maint
Depends on:
Blocks: 622558
 
 
Reported: 2013-06-06 17:19 UTC by Javier Jardón (IRC: jjardon)
Modified: 2016-02-14 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make GConf depency completely optional (1.21 KB, patch)
2013-06-06 17:19 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review

Description Javier Jardón (IRC: jjardon) 2013-06-06 17:19:46 UTC 
Created attachment 246176 [details] [review]
Make GConf depency completely optional

So we do not need the GConf macros to bootstrap the module

Patch atached
Comment 1 Christian Persch 2013-06-06 17:30:07 UTC 
+    m4_ifdef([AM_GCONF_SOURCE_2],[AM_GCONF_SOURCE_2])

Don't you need to define the GCONF_SCHEMAS_INSTALL conditional in the else branch here, too?
Comment 2 Javier Jardón (IRC: jjardon) 2013-06-11 13:22:30 UTC 
(In reply to comment #1)
> +    m4_ifdef([AM_GCONF_SOURCE_2],[AM_GCONF_SOURCE_2])
> 
> Don't you need to define the GCONF_SCHEMAS_INSTALL conditional in the else
> branch here, too?

I do not think is needed: Its not defined, so the conditions in src/Makefile.am will be false
Comment 3 Christian Persch 2013-06-11 15:16:47 UTC 
automake conditionals must *always* be defined.
Comment 4 Christian Persch 2013-09-14 12:29:51 UTC 
Got an updated patch?
Comment 5 Paolo Borelli 2013-12-23 09:37:15 UTC 
any specific reason to keep the gconf backend at all?
Comment 6 Christian Persch 2013-12-23 18:40:30 UTC 
None, except that the gsettings port (on branch) isn't ready yet.
Comment 7 Matthias Clasen 2014-03-13 12:20:51 UTC 
how is it not ready ? and which branch would that be ?
Comment 8 Javier Jardón (IRC: jjardon) 2014-03-13 13:48:18 UTC 
https://git.gnome.org/browse/aisleriot/log/?h=wip/redesign
Comment 9 Michael Catanzaro 2015-01-29 16:55:34 UTC 
Whenever this bug is resolved, please revert the patch in bug #724771.
Comment 10 Christian Persch 2016-02-14 09:53:17 UTC 
Do NOT revert bug #724771; gnome-world is where aisleriot belongs.
Comment 11 Michael Catanzaro 2016-02-14 15:27:39 UTC 
If that's what you prefer.

Personally, I think gnome-apps is a better place; gnome-world is a dumping ground for third-party stuff that we never build or test, and the modules in it are mostly all broken. gnome-apps is for tested apps that, while not installed by default, are "good" GNOME apps that comply with the GNOME HIG; aisleriot certainly qualifies.

Another hint that gnome-apps is a good place is that you follow the GNOME release cycle.

Inclusion in gnome-apps would also make it much easier for new contributors to build aisleriot, as it requires some amount of expertise with jhbuild to figure out how to enable gnome-world. If you put it in gnome-apps, we would also add it to GNOME Continuous.

But, up to you!