GNOME Bugzilla – Bug 701736
Add PackageKit integration
Last modified: 2016-01-05 14:12:58 UTC
We should add PackageKit integration so that the users could easily install missing GStreamer plugins.
Needs info on how the UI reacts to playing of unsupported files in gnome-music. Designer feedback required.
According to https://bugzilla.gnome.org/page.cgi?id=fields.html#status NEEDINFO More information from the reporter is needed to proceed further in fixing this bug. This should not be used when someone needs more information from a developer - a NEW or ASSIGNED bug implicitly needs more information from the developer. If you need to ask a designer for feedback, just ask them directly or CC them :D (btw, jimmac is already in CC).
We went back and forth on this one, if I recall correctly. I think the conclusion was to show unsupported tracks in the UI but indicate that they couldn't be played. I have recently been looking at the design of packagekit integration as a part of the new software app. This could have some impact on music. https://raw.github.com/gnome-design-team/gnome-mockups/master/software/version2/wire-codec-install.png As you can see, one of the goals is to check that the required codecs are installed at import time. Basically, when you add a track to music, that is the time the check should be performed.
Thanks Allan, seems clear to me. Should we display the warning once on startup or each time user may play unsupported media - e.g. on selected album view or artists?
The wireframes have been updated recently - please check them over to ensure they make sense. (In reply to comment #5) > Thanks Allan, seems clear to me. Should we display the warning once on startup > or each time user may play unsupported media - e.g. on selected album view or > artists? The designs suggest: 1. Show an in-app notification when unsupported music appears in the collection. 2. If the user tries to play unsupported music, show a dialog.
(In reply to comment #6) ... > The designs suggest: > > 1. Show an in-app notification when unsupported music appears in the > collection. > 2. If the user tries to play unsupported music, show a dialog. You could add 2 to start with, and deal with 1 later...
Some updates on the topic in totem: https://bugzilla.gnome.org/show_bug.cgi?id=744610
(In reply to Allan Day from comment #7) > (In reply to comment #6) > ... > > The designs suggest: > > > > 1. Show an in-app notification when unsupported music appears in the > > collection. > > 2. If the user tries to play unsupported music, show a dialog. > > You could add 2 to start with, and deal with 1 later... Here's a patch that adds an initial implementation of 2:
Created attachment 297963 [details] [review] player: Add support for installing missing gstreamer plugins
Created attachment 297964 [details] [review] player: Avoid a hard dep on gstreamer 1.5 Only use the new functions if we have new enough gst-plugins-base.
Created attachment 297965 [details] [review] downstream patch: Reduce gstreamer version requirement We carry backported gstreamer1-plugins-base patches that add the required new symbols.
Crashes for me in jhbuild: Traceback (most recent call last):
+ Trace 234717
self._handle_missing_plugins()
retval = fn(*v, **k)
self._start_plugin_installation(missing_plugin_messages, True)
install_ctx.set_desktop_id('gnome-music.desktop');
Probably my gst is too old, will see if updating helps
Yup, definitely too old gst. Note that the last patch is a downstream patch for F22 and not something that should go upstream. gstreamer1-plugins-base-1.4.5-2.fc22 has patches that backport set_desktop_id() and friends.
Can I push this to master so that we get some rawhide testing during the F23 cycle?
(In reply to Kalev Lember from comment #15) > Can I push this to master so that we get some rawhide testing during the F23 > cycle? Right, pushed to master: https://git.gnome.org/browse/gnome-music/commit/?id=81529bac3a5855d4b104230bf97425ec847c8685 https://git.gnome.org/browse/gnome-music/commit/?id=d7695285b0419541a3492ef1d85d8076fcc49d2b https://git.gnome.org/browse/gnome-music/commit/?id=673c17a1aedde45ac623b4b285a33afcc0c01016 Keeping this open for more tests
Thanks! One minor nit - the last patch was meant as a downstream patch for Fedora to make it work with the gstreamer 1.4 there that has new features backported from master - can you revert it upstream please?
Review of attachment 297963 [details] [review]: Comitted
Review of attachment 297964 [details] [review]: Comitted
Review of attachment 297965 [details] [review]: Committed
If more tests are required it would probably be best to use a separate bug, so closing for now. Also removing the 3.18 target-milestone.