After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701713 - vpn-manager: fix PropertiesChanged on NMVpnConnection
vpn-manager: fix PropertiesChanged on NMVpnConnection
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-06 12:01 UTC by Dan Winship
Modified: 2013-06-10 13:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vpn-manager: fix PropertiesChanged on NMVpnConnection (1.75 KB, patch)
2013-06-06 12:01 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2013-06-06 12:01:28 UTC
fixes the applet-doesn't-notice-when-vpn-connect-succeeds bug in master
Comment 1 Dan Winship 2013-06-06 12:01:30 UTC
Created attachment 246149 [details] [review]
vpn-manager: fix PropertiesChanged on NMVpnConnection

We need to register NMVpnConnection's properties with the
PropertiesChanged signal (which it inherits from NMActiveConnection)
or it will ignore them.
Comment 2 Jiri Klimes 2013-06-10 08:23:50 UTC
(In reply to comment #1)
> Created an attachment (id=246149) [details] [review]
> vpn-manager: fix PropertiesChanged on NMVpnConnection
> 
> We need to register NMVpnConnection's properties with the
> PropertiesChanged signal (which it inherits from NMActiveConnection)
> or it will ignore them.

Looks good.
Comment 3 Dan Winship 2013-06-10 13:36:02 UTC
Attachment 246149 [details] pushed as 8feb387 - vpn-manager: fix PropertiesChanged on NMVpnConnection