After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701712 - brokenness in master with NMDeviceModem and :ip-iface
brokenness in master with NMDeviceModem and :ip-iface
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: Mobile broadband
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-06 11:51 UTC by Dan Winship
Modified: 2013-06-07 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for the issue. (3.42 KB, patch)
2013-06-07 16:15 UTC, Aleksander Morgado 		committed Details | Review

Description Dan Winship 2013-06-06 11:51:59 UTC 
When I made the various nm_device_*_new() functions take an NMPlatformLink, I cleaned up some stuff in nm-device.c, one of which was getting rid of this in set_property():

>-       case PROP_IP_IFACE:
>-               break;

which clearly wasn't doing anyone any good. But apparently, NMDeviceModem does try to set ip-iface at construct time anyway. So this didn't work before my commit, but now it causes warnings since the property is read-only now. Anyway, is this just cruft, or has it been broken in master for a while and no one noticed, or...?
Comment 1 Aleksander Morgado 2013-06-07 16:09:19 UTC 
That property was meant to be set during GObject construction for modems managed by the old MM, but not setting it didn't end up harming because when querying nm_device_get_ip_iface(), this would end up returning 'iface' instead of 'ip_iface' if the latter was unset; and actually 'iface' is set to the modem's data port when using the old MM... that's why we didn't find the bug before. When using the new MM, ip-iface is set during the Bearer creation using nm_device_set_ip_iface(), so it was also unaffected.

Will prepare a patch to fix this.
Comment 2 Aleksander Morgado 2013-06-07 16:15:51 UTC 
Created attachment 246256 [details] [review]
Patch for the issue.
Comment 3 Dan Winship 2013-06-07 16:18:44 UTC 
committed. thanks