After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701599 - compositor: Add missing NULL check
compositor: Add missing NULL check
Status: RESOLVED DUPLICATE of bug 722266
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-04 14:30 UTC by Florian Müllner
Modified: 2014-04-26 08:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
compositor: Add missing NULL check (1.27 KB, patch)
2013-06-04 14:30 UTC, Florian Müllner 		none Details | Review

Description Florian Müllner 2013-06-04 14:30:27 UTC 
See patch (and https://bugzilla.redhat.com/show_bug.cgi?id=970152 for a downstream report)
Comment 1 Florian Müllner 2013-06-04 14:30:30 UTC 
Created attachment 246008 [details] [review]
compositor: Add missing NULL check

Both cogl_texture_new_from_data() and meta_texture_rectangle_new()
may return NULL on failure, leading to a crash if we try to
dereference it later on.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-06-04 17:07:39 UTC 
Review of attachment 246008 [details] [review]:

What's the failure you're seeing? It's quite serious, and we'd just get garbage displayed to the screen, so I think crashing is a better option.
Comment 3 Florian Müllner 2013-06-04 17:20:15 UTC 
(In reply to comment #2)
> What's the failure you're seeing

If I was seeing this myself, I wouldn't file a fedora bug about it :-)
Comment 4 Florian Müllner 2014-04-26 08:04:27 UTC 

*** This bug has been marked as a duplicate of bug 722266 ***