After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701598 - rhythmbox seems to always be compiled with --enable-uninstalled-build
rhythmbox seems to always be compiled with --enable-uninstalled-build
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-04 14:22 UTC by Lionel Landwerlin
Modified: 2013-10-22 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure.ac: use right variable for uninstalled-build (1021 bytes, patch)
2013-06-04 14:23 UTC, Lionel Landwerlin 		rejected Details | Review

Description Lionel Landwerlin 2013-06-04 14:22:49 UTC 
I believe the configure.ac is missing a enable_uninstalled=no.
Instead of manually setting the variable, AC_ARG_ENABLE already provides a prefilled variable.
Comment 1 Lionel Landwerlin 2013-06-04 14:23:35 UTC 
Created attachment 246007 [details] [review]
configure.ac: use right variable for uninstalled-build
Comment 2 Jonathan Matthew 2013-10-22 12:55:49 UTC 
Review of attachment 246007 [details] [review]:

no, $enableval is the right thing to do here
Comment 3 Jonathan Matthew 2013-10-22 13:00:10 UTC 
fixed in commit a41cd89