After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701549 - orca-autostart.desktop always enable speech and braille
orca-autostart.desktop always enable speech and braille
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-03 18:06 UTC by Javier Hernández
Modified: 2013-06-04 03:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix #1 (783 bytes, patch)
2013-06-03 18:16 UTC, Javier Hernández 		reviewed Details | Review
Proposed fix #2 (1.22 KB, patch)
2013-06-03 19:46 UTC, Javier Hernández 		committed Details | Review

Description Javier Hernández 2013-06-03 18:06:54 UTC 
orca-autostart.desktop launches orca with speech even if the starting profile has enableSpeech preference to false. (I assumed the same for enableBraille)

Environment:
 - Fedora 18
 - Orca 3.6.3

Steps to reproduce:
1.- Turn the Screen Reader on by using the UAP
2.- Open Orca Preferences Window
3.- Go to "Speech" tab and disable speech by using the "Enable Speech" checkbox.
4.- Click OK (will save this setting) and turn the Screen Reader off
5.- Turn the Screen Reader on by using the UAP again

Result:

Speech synthesis is enabled

Expected result:

Speech synthesis should be disabled

Seems that the commandline-starting options are mandatory. As a fix, I would remove the "--enable speech,braille" from the orca-autostart.desktop file. If you are ok with this solution I can provide a patch of it. 

Cheers,
Javi
Comment 1 Javier Hernández 2013-06-03 18:16:49 UTC 
Created attachment 245948 [details] [review]
Proposed fix #1
Comment 2 Joanmarie Diggs (IRC: joanie) 2013-06-03 19:07:34 UTC 
Comment on attachment 245948 [details] [review]
Proposed fix #1

The side effect of this change is that a user in a new environment (and presumably GDM) will not have braille enabled until he/she enables it. And for users who depend upon braille, that's an unfortunate catch-22.

So I'm okay with this change *if* at the same time you make a change to settings.py to enable braille by default. If you agree, please go ahead and commit the patch with that change. If not, let's chat. :)

Thanks for the report and patch!
Comment 3 Javier Hernández 2013-06-03 19:46:37 UTC 
Created attachment 245956 [details] [review]
Proposed fix #2

Hi Joanie!

I was not sure about the collateral effects of the patch, thank you.
Here is a new patch with the changes you have recommended.

Thanks for reviewing it so fast! ;)

Regards,
Javi