GNOME Bugzilla – Bug 701504
Deprecate allowed bands and network type setting in GSM connections
Last modified: 2013-06-05 18:00:35 UTC
NetworkManager shouldn't request to use specific bands or network types (allowed/preferred modes) to ModemManager. See https://mail.gnome.org/archives/networkmanager-list/2013-May/msg00233.html
Created attachment 245905 [details] [review] Patch to deprecate the settings
Created attachment 245906 [details] [review] Patch to remove the allowed-modes request in ModemManager1 modems
Maybe, we could also add a note about not using the properties in 0.9.10 directly into properties blurb description; like: diff --git a/libnm-util/nm-setting-gsm.c b/libnm-util/nm-setting-gsm.c index cc3408b..b922121 100644 --- a/libnm-util/nm-setting-gsm.c +++ b/libnm-util/nm-setting-gsm.c @@ -682,7 +682,9 @@ nm_setting_gsm_class_init (NMSettingGsmClass *setting_class) "specific network technologies. The permitted values " "are: -1: any, 0: 3G only, 1: GPRS/EDGE only, " "2: prefer 3G, 3: prefer 2G, 4: prefer 4G/LTE, 5: 4G/LTE only. " - "Note that not all devices allow network preference control.", + "Notes: This property is deprecated and NetworkManager from 0.9.10 " + "onwards doesn't use this property when talking to ModemManager.", + "Also, not all devices allow network preference control.", NM_SETTING_GSM_NETWORK_TYPE_ANY, NM_SETTING_GSM_NETWORK_TYPE_4G, NM_SETTING_GSM_NETWORK_TYPE_ANY, Otherwise, the patches looks good to me.
Created attachment 245920 [details] [review] Patch to deprecate the settings, added notes in the properties.
(In reply to comment #3) > Maybe, we could also add a note about not using the properties in 0.9.10 > directly into properties blurb description; like: > > diff --git a/libnm-util/nm-setting-gsm.c b/libnm-util/nm-setting-gsm.c > index cc3408b..b922121 100644 > --- a/libnm-util/nm-setting-gsm.c > +++ b/libnm-util/nm-setting-gsm.c > @@ -682,7 +682,9 @@ nm_setting_gsm_class_init (NMSettingGsmClass > *setting_class) > "specific network technologies. The permitted values > " > "are: -1: any, 0: 3G only, 1: GPRS/EDGE only, " > "2: prefer 3G, 3: prefer 2G, 4: prefer 4G/LTE, 5: > 4G/LTE only. " > - "Note that not all devices allow network preference > control.", > + "Notes: This property is deprecated and NetworkManager > from 0.9.10 " > + "onwards doesn't use this property when > talking to ModemManager.", > + "Also, not all devices allow network preference > control.", > NM_SETTING_GSM_NETWORK_TYPE_ANY, > NM_SETTING_GSM_NETWORK_TYPE_4G, > NM_SETTING_GSM_NETWORK_TYPE_ANY, > > > Otherwise, the patches looks good to me. I added those notes in the properties now, updated patch already submitted.
(In reply to comment #2) > Created an attachment (id=245906) [details] [review] > Patch to remove the allowed-modes request in ModemManager1 modems Pushed.
(In reply to comment #4) > Created an attachment (id=245920) [details] [review] > Patch to deprecate the settings, added notes in the properties. Pushed with some fixes to not abort compile becuase NM is internally still using these for old MM.