GNOME Bugzilla – Bug 701474
Error building glibmm due to extra comma in glib/gtestutils.h
Last modified: 2013-06-03 07:44:59 UTC
We like to build glibmm and other C++ packages with compiler flags -pedantic -Wall -Wextra -Wformat-security -Wno-long-long -Werror Such builds now fail due to an extra comma in glib/glib/gtestutils.h. typedef enum { G_TEST_SUBPROCESS_INHERIT_STDIN = 1 << 0, G_TEST_SUBPROCESS_INHERIT_STDOUT = 1 << 1, G_TEST_SUBPROCESS_INHERIT_STDERR = 1 << 2, } GTestSubprocessFlags; According to pedantic C and C++, the comma after the last entry in the enum definition is not allowed. Excerpt from the compilation error messages when glibmm is built: /opt/gnome/include/glib-2.0/glib/gtestutils.h:183:44: error: comma at end of enumerator list [-Werror=edantic] cc1plus: all warnings being treated as errors This enum was added with this commit: https://git.gnome.org/browse/glib/commit/?id=960f5500e22d505a5dccbff51ccbc8ab969f0851 Build date and platform: Ubuntu 12.04. Source code of glib from git's master branch, built with jhbuild on 2013-06-02.
Created attachment 245873 [details] [review] patch: Remove extra comma in gtestutils.h
Review of attachment 245873 [details] [review]: Ok.
I have pushed the patch to the master branch https://git.gnome.org/browse/glib/commit/?id=9acc480d72e9140ec1fa34d780c6d924c7a71aec