After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701472 - launch-environment: Tighten permissions on directories we create
launch-environment: Tighten permissions on directories we create
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks: 701100
 
 
Reported: 2013-06-02 17:57 UTC by Rui Matos
Modified: 2013-06-04 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
launch-environment: Tighten permissions on directories we create (1.15 KB, patch)
2013-06-02 17:57 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-06-02 17:57:05 UTC 
This is particularly important for gnome-initial-setup's home
directory since private user data will be stored there.
Comment 1 Rui Matos 2013-06-02 17:57:08 UTC 
Created attachment 245871 [details] [review]
launch-environment: Tighten permissions on directories we create
Comment 2 Ray Strode [halfline] 2013-06-03 18:13:43 UTC 
Review of attachment 245871 [details] [review]:

seems fine.

::: daemon/gdm-launch-environment.c
@@ +412,3 @@
                                GError     **error)
 {
+        if (mkdir (path, 0700) == -1 && errno != EEXIST) {

maybe we should consolidate this function and the other ensure_dir function in main.c to gdm-common or something.  Anyway that's orthogonal to this change
Comment 3 Ray Strode [halfline] 2013-06-04 11:51:16 UTC 
Attachment 245871 [details] pushed as 64894dc - launch-environment: Tighten permissions on directories we create