GNOME Bugzilla – Bug 701409
Missing allow-none annotations in g_uri_unescape_string and g_uri_escape_string
Last modified: 2013-06-19 15:28:17 UTC
Well, I think the summary explains everything.
Created attachment 245812 [details] [review] g_uri_unescape_string
Created attachment 245813 [details] [review] g_uri_escape_string
Review of attachment 245813 [details] [review]: Looks good
Review of attachment 245812 [details] [review]: Doesn't make much sense to me to mark escaped_string as allow-none.
Created attachment 246376 [details] [review] g_uri_unescape_string Thanks for reviewing my commit. (In reply to comment #4) > Review of attachment 245812 [details] [review]: > > Doesn't make much sense to me to mark escaped_string as allow-none. I copied it from g_uri_unescape_segment, since it also calls that function. Removed it and related documentation for return in this new patch.
Review of attachment 246376 [details] [review]: looks good now
The following fixes have been pushed: 19e2008 g_uri_unescape_string: Mention (allow-none)/%NULL in documentation 8d29a5a g_uri_escape_string: Add missing allow-none annotation
Created attachment 247267 [details] [review] g_uri_unescape_string: Mention (allow-none)/%NULL in documentation
Created attachment 247268 [details] [review] g_uri_escape_string: Add missing allow-none annotation