After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701356 - Update the windows backend to work with latest Cogl
Update the windows backend to work with latest Cogl
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: win32
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-31 13:24 UTC by Neil Roberts
Modified: 2013-07-12 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update the dependencies for the MinGW build script (4.64 KB, patch)
2013-05-31 13:24 UTC, Neil Roberts 		accepted-commit_now Details | Review
win32: Disable event retrieval in Cogl (2.49 KB, patch)
2013-05-31 13:24 UTC, Neil Roberts 		accepted-commit_now Details | Review

Description Neil Roberts 2013-05-31 13:24:07 UTC 
Cogl has slightly broken its API when using the Win32 backend because it will now set up its own GSource to consume windows messages. This could end up competing with Clutter's GSource to do the same thing (although in practice it doesn't seem to cause any problems).
Comment 1 Neil Roberts 2013-05-31 13:24:56 UTC 
Created attachment 245725 [details] [review]
Update the dependencies for the MinGW build script

As the binaries from Tor Lillqvist are no longer being kept up-to-date
this also builds more of the deps from source.
Comment 2 Neil Roberts 2013-05-31 13:24:59 UTC 
Created attachment 245726 [details] [review]
win32: Disable event retrieval in Cogl

Since commit 4543ed6ac3af in Cogl, Cogl will now try to consume
Windows message itself. This doesn't really cause any problems because
both message loops just call DispatchMessage which will cause the
message to be routed through Clutter's window procedure either way.
However, it's not great to have two sources listening for messages so
this patch disables Cogl's message retrieval.
Comment 3 Emmanuele Bassi (:ebassi) 2013-07-12 16:43:57 UTC 
Review of attachment 245726 [details] [review]:

looks okay.
Comment 4 Emmanuele Bassi (:ebassi) 2013-07-12 16:44:49 UTC 
Review of attachment 245725 [details] [review]:

I assume you tested it, so it's okay by me.
Comment 5 Neil Roberts 2013-07-12 17:00:39 UTC 
Yes, I tested it. Well, under Wine at least. Thanks for the review. I've pushed them both to the clutter-1.16 branch.