GNOME Bugzilla – Bug 701285
Build error exposed in gnome-control-center 3.9.2
Last modified: 2013-06-03 12:55:01 UTC
Due to an error in header inclusion vs defines, gnome-control-center manages to expose an error: [ 35s] libgd/gd-types-catalog.c:29:40: fatal error: gd-toggle-pixbuf-renderer.h: No such file or directory The general issue is: Makefile.am if LIBGD__VIEW_COMMON view_common_sources = \ libgd/gd-main-view-generic.c \ libgd/gd-main-view-generic.h \ libgd/gd-styled-text-renderer.c \ libgd/gd-styled-text-renderer.h \ libgd/gd-two-lines-renderer.c \ libgd/gd-two-lines-renderer.h \ $(NULL) endif if LIBGD_MAIN_ICON_VIEW main_icon_view_sources = \ libgd/gd-main-icon-view.c \ libgd/gd-main-icon-view.h \ libgd/gd-toggle-pixbuf-renderer.c \ libgd/gd-toggle-pixbuf-renderer.h \ $(NULL) endif versus gd.h: #ifdef LIBGD__VIEW_COMMON # include <libgd/gd-main-view-generic.h> # include <libgd/gd-styled-text-renderer.h> # include <libgd/gd-toggle-pixbuf-renderer.h> # include <libgd/gd-two-lines-renderer.h> #endif => gd-toggle-pixbuf-renderer.h is only added to the resulting tarballs when LIBGD_MAIN_ICON_VIEW is defined, but it is being used when LIBGD__VIEW_COMMON is being defined already.
Created attachment 245882 [details] [review] view-common: Dist missing files needed by gd-types-catalog.c ... to unbreak gnome-control-center disted tarball after commit 51d7519c5c0c7228f4995655e184cd4b24deadce.
Review of attachment 245882 [details] [review]: Looks good to me, thanks.
Attachment 245882 [details] pushed as 5bcd11f - view-common: Dist missing files needed by gd-types-catalog.c