After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701281 - empathy-sanity-checker: Include empathy-keyring.h when HAVE_UOA is defined.
empathy-sanity-checker: Include empathy-keyring.h when HAVE_UOA is defined.
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-30 14:35 UTC by Iain Lane
Modified: 2013-05-31 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
empathy-sanity-checker: Include empathy-keyring.h when HAVE_UOA is defined. (837 bytes, patch)
2013-05-30 14:35 UTC, Iain Lane 		committed Details | Review

Description Iain Lane 2013-05-30 14:35:16 UTC 
See the 3.8.3 buildlog at:

  https://launchpadlibrarian.net/141094778/buildlog_ubuntu-saucy-amd64.empathy_3.8.3-0ubuntu1_FAILEDTOBUILD.txt.gz

(which may be GCed at some point in the future; sorry).

,----
| empathy-sanity-cleaning.c: In function 'uoa_set_account_password_cb':
| empathy-sanity-cleaning.c:322:3: warning: implicit declaration of function 'empathy_keyring_set_account_password_finish' [-Wimplicit-function-declaration]
|    if (!empathy_keyring_set_account_password_finish (data->new_account, result,
|    ^
`----

If HAVE_UOA is defined, we need to include empathy-keyring.h for this.
Comment 1 Iain Lane 2013-05-30 14:35:17 UTC 
Created attachment 245649 [details] [review]
empathy-sanity-checker: Include empathy-keyring.h when HAVE_UOA is defined.

We use empathy_keyring_set_account_password_finish and friends from
here.
Comment 2 Guillaume Desmottes 2013-05-31 13:05:40 UTC 
Attachment 245649 [details] pushed as 3a02bb0 - empathy-sanity-checker: Include empathy-keyring.h when HAVE_UOA is defined.
Comment 3 Guillaume Desmottes 2013-05-31 13:05:59 UTC 
Thanks for the patch!