After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701280 - is_palm_device defined but not used
is_palm_device defined but not used
Status: RESOLVED WONTFIX
Product: gnome-bluetooth
Classification: Core
Component: sendto
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2013-05-30 14:34 UTC by Emilio Pozuelo Monfort
Modified: 2013-11-13 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add palm check back (1.28 KB, patch)
2013-05-30 14:36 UTC, Emilio Pozuelo Monfort
none Details | Review

Description Emilio Pozuelo Monfort 2013-05-30 14:34:38 UTC
sendto/main.c has an is_palm_device() function that is currently unused because the code that used it was commented out.
Comment 1 Emilio Pozuelo Monfort 2013-05-30 14:36:14 UTC
Created attachment 245650 [details] [review]
Add palm check back

This adds the Palm check back. The only issue is that the error code doesn't actually exist in obexd. We'd need to make it match the actual error returned by obexd before committing something like this.
Comment 2 Bastien Nocera 2013-11-13 16:51:30 UTC
commit 0b4233ee3bda7582cd558b0d22b80871062efdff
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Nov 13 17:50:05 2013 +0100

    sendto: Simplify error message fetching
    
    And remove the dead "Palm" special-casing, as obexd's error messages
    are too broad to do anything special in the UI.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=701280