After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701254 - Artist label in albums and artists view not ellipsized
Artist label in albums and artists view not ellipsized
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-30 09:02 UTC by Arnel Borja
Modified: 2013-06-02 14:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ellipsize in the middle (889 bytes, patch)
2013-05-30 09:02 UTC, Arnel Borja 		accepted-commit_now Details | Review
Ellipsize in the end (886 bytes, patch)
2013-05-30 09:02 UTC, Arnel Borja 		rejected Details | Review
Screenshot (228.76 KB, image/png)
2013-06-02 14:26 UTC, Arnel Borja 		  Details
Ellipsize in the middle in Artists view (796 bytes, patch)
2013-06-02 14:36 UTC, Arnel Borja 		none Details | Review

Description Arnel Borja 2013-05-30 09:02:01 UTC 
Created attachment 245619 [details] [review]
Ellipsize in the middle

The tree view in the album view are ellipsized in the end (and it is ellipsized in the middle in the toolbar), but when I select an album in the said tree view, it is not ellipsized at all, forcing the window to change size when the artist's name is too long.

Because I don't where it should be ellipsized (sometimes, gnome-music uses middle, sometimes end; but probably middle since it is was the album title uses?), I just provided two patches. Only one is needed to fix it.
Comment 1 Arnel Borja 2013-05-30 09:02:40 UTC 
Created attachment 245620 [details] [review]
Ellipsize in the end
Comment 2 Vadim Rutkovsky 2013-05-30 09:34:38 UTC 
Review of attachment 245619 [details] [review]:

Substituted by the second patch
Comment 3 Seif Lotfy 2013-06-01 16:22:09 UTC 
Look good to me. please push
Comment 4 Arnel Borja 2013-06-02 14:26:21 UTC 
Created attachment 245857 [details]
Screenshot
Comment 5 Arnel Borja 2013-06-02 14:36:45 UTC 
Created attachment 245858 [details] [review]
Ellipsize in the middle in Artists view
Comment 6 Vadim Rutkovsky 2013-06-02 14:40:49 UTC 
Review of attachment 245619 [details] [review]:

My initial review was incorrect - ellipse should be in the middle
Comment 7 Vadim Rutkovsky 2013-06-02 14:41:03 UTC 
Review of attachment 245620 [details] [review]:

not needed
Comment 8 Vadim Rutkovsky 2013-06-02 14:54:50 UTC 
Thanks, pushed the needed patches