After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701249 - build failure: error: 'GsdKeyboardManagerPrivate' has no member named 'ibus_cancellable'
build failure: error: 'GsdKeyboardManagerPrivate' has no member named 'ibus_c...
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
3.9.x
Other Windows
: Normal normal
: ---
Assigned To: Rui Matos
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-30 07:47 UTC by Dominique Leuenberger
Modified: 2013-05-30 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: Fix build without IBus (1.04 KB, patch)
2013-05-30 09:42 UTC, Rui Matos
committed Details | Review

Description Dominique Leuenberger 2013-05-30 07:47:03 UTC
While building g-s-d 3.9.2, I am presented with this build error:

[  151s] libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../gnome-settings-daemon -I../../data -I../../plugins/common -DDATADIR=\"/usr/share/gnome-settings-daemon\" -DLIBEXECDIR=\"/usr/lib/gnome-settings-daemon-3.0\" -DGNOME_SETTINGS_LOCALEDIR=\"/usr/share/locale\" -DG_LOG_DOMAIN=\"keyboard-plugin\" -DPLUGIN_NAME=\"keyboard\" -pthread -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gsettings-desktop-schemas -pthread -I/usr/include/gnome-desktop-3.0 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gsettings-desktop-schemas -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -c gsd-keyboard-manager.c  -fPIC -DPIC -o .libs/libkeyboard_la-gsd-keyboard-manager.o
[  151s] gsd-keyboard-manager.c: In function 'handle_dbus_method_call':
[  151s] gsd-keyboard-manager.c:1518:51: error: 'GsdKeyboardManagerPrivate' has no member named 'ibus_cancellable'
[  151s] gsd-keyboard-manager.c: At top level:
[  151s] gsd-keyboard-manager.c:133:17: warning: 'set_gtk_im_module' declared 'static' but never defined [-Wunused-function]
[  151s] gsd-keyboard-manager.c:1475:1: warning: 'increment_set_input_source_ops' defined but not used [-Wunused-function]
[  151s] make[3]: *** [libkeyboard_la-gsd-keyboard-manager.lo] Error 1
[  151s] make[3]: Leaving directory `/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.9.2/plugins/keyboard'
[  151s] make[2]: *** [all-recursive] Error 1
[  151s] make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.9.2/plugins'
[  151s] make[1]: *** [all-recursive] Error 1
[  151s] make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.9.2'
Comment 1 Dominique Leuenberger 2013-05-30 07:52:33 UTC
oh.. one note:

I configured with --disable-ibus (due to missing ibus 1.5 in my system.
Comment 2 Rui Matos 2013-05-30 09:42:37 UTC
Created attachment 245625 [details] [review]
keyboard: Fix build without IBus

--

This is also needed in 3.8.
Comment 3 Bastien Nocera 2013-05-30 10:06:32 UTC
Review of attachment 245625 [details] [review]:

Looks good.

::: plugins/keyboard/gsd-keyboard-manager.c
@@ +1490,3 @@
                          * ibus_bus_set_global_engine_async() call
                          * going on. */
+#ifdef HAVE_IBUS

Put it before the comment, maybe?
Comment 4 Rui Matos 2013-05-30 11:57:41 UTC
Attachment 245625 [details] pushed as 22654fd - keyboard: Fix build without IBus