After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701232 - Painting tools still slow when used in Quick Mask mode
Painting tools still slow when used in Quick Mask mode
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: Tools
git master
Other Linux
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks: 141797
 
 
Reported: 2013-05-29 22:59 UTC by Przemysław Gołąb (n-pigeon)
Modified: 2018-05-24 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Przemysław Gołąb (n-pigeon) 2013-05-29 22:59:44 UTC
Daniel Sabo asked for reporting this as a bug, for future TODO.
Comment 1 Daniel Sabo 2013-05-31 22:56:21 UTC
I've committed some babl conversions that should improve this, before it was going thought the slow reference paths for Y' u8 -> RGBA float -> Y' u8.
Comment 2 Przemysław Gołąb (n-pigeon) 2013-06-01 11:11:05 UTC
Hmmm I think it is slightly faster now, but change is not very noticeable so I'm not sure.
Comment 3 Michael Natterer 2013-09-28 15:55:29 UTC
There have been further changes, does it still happen?
Comment 4 Przemysław Gołąb (n-pigeon) 2013-09-28 22:59:25 UTC
(In reply to comment #3)
> There have been further changes, does it still happen?

Yes, in quick mask mode painting tools are still much, much slower.
Comment 5 Daniel Sabo 2013-09-29 02:05:45 UTC
There are 2-3 things that cause this issue:

1. The gegl:opacity operation works on linear RGBA only (the same code would work on R'G'B' because it doesn't modify color data, I already have part of a better version around somewhere).
2. The gegl:color operation always outputs "RGBA float" data, we will probably have to add a "format" property.
3. (Optional) When OpenCL is enabled the gegl:opacity operation uses an OpenCL version, which will be very slow surrounded by CPU based operations.
Comment 6 Michael Natterer 2013-10-17 23:15:53 UTC
This fixes the gegl:color part:

commit e0c64a817dee23164f46046f82dfcc8edbcc8ce8
Author: Michael Natterer <mitch@gimp.org>
Date:   Fri Oct 18 01:01:26 2013 +0200

    Bug 701232 - Painting tools still slow when used in Quick Mask mode
    
    Set the format of GimpChannel's gegl:color node depending on whether
    the buffer is linear or gamma-corrected.

 app/core/gimpchannel.c | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)
Comment 7 GNOME Infrastructure Team 2018-05-24 13:43:44 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/476.