After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701153 - Fails to build with perl 5.18
Fails to build with perl 5.18
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-28 20:27 UTC by Emilio Pozuelo Monfort
Modified: 2013-05-28 21:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (955 bytes, patch)
2013-05-28 20:28 UTC, Emilio Pozuelo Monfort
none Details | Review

Description Emilio Pozuelo Monfort 2013-05-28 20:27:34 UTC
From http://bugs.debian.org/710038

Building with perl 5.18.0 installed results in:

....
cd gucharmap && ./gen-guch-unicode-tables.pl 6.1.0 /usr/share/unicode
syntax error at ./gen-guch-unicode-tables.pl line 377, near "kTang kKorean
kJapaneseKun kJapaneseOn)"
  (Might be a runaway multi-line () string starting on line 376)
Global symbol "$f" requires explicit package name at ./gen-guch-unicode-
tables.p
l line 379.
....
syntax error at ./gen-guch-unicode-tables.pl line 413, near "}"
../gen-guch-unicode-tables.pl has too many errors.
make: *** [debian/stamp-gen-unicode-tables] Error 255
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Command exited with non-zero status 2

Reason are "for" statements (on lines 376 and 426 of gen-guch-unicode-
tables.pl)
that iterate over a qw() list, but omit the parentheses around them.
This drew a deprecation warning in perl 5.16 and is an error in 5.18
(cf.
http://search.cpan.org/~rjbs/perl-5.18.0/pod/perldelta.pod#qw%28...%29_can_no_longer_be_used_as_parentheses).
Reason are "for" statements (on lines 376 and 426 of gen-guch-unicode-
tables.pl)
that iterate over a qw() list, but omit the parentheses around them.
This drew a deprecation warning in perl 5.16 and is an error in 5.18
(cf.
http://search.cpan.org/~rjbs/perl-5.18.0/pod/perldelta.pod#qw%28...%29_can_no_longer_be_used_as_parentheses).
Comment 1 Emilio Pozuelo Monfort 2013-05-28 20:28:49 UTC
Created attachment 245490 [details] [review]
patch

Patch from Roderich Schupp <roderich.schupp@gmail.com>
Comment 2 Christian Persch 2013-05-28 20:48:00 UTC
Just to be clear; this will still work in perl 5.14 (which is all F17 has), right? If so, ok to commit.

BTW: You are *NOT* supposed to run this script as part of the build process! It is only intended to be used by the gucharmap maintainer. In particular, it's not guaranteed to work when used against a different unicode version (both a lower or a higher version) than the one gucharmap currently incorporates.
Comment 3 Emilio Pozuelo Monfort 2013-05-28 21:14:21 UTC
(In reply to comment #2)
> Just to be clear; this will still work in perl 5.14 (which is all F17 has),
> right? If so, ok to commit.

Yes, works fine with 5.14. Committed as 01a28fc1f118cab76cde4274143cd1d59aa20b98

> BTW: You are *NOT* supposed to run this script as part of the build process! It
> is only intended to be used by the gucharmap maintainer. In particular, it's
> not guaranteed to work when used against a different unicode version (both a
> lower or a higher version) than the one gucharmap currently incorporates.

It seems that was made in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603405. If by not guaranteed to work you mean that it will fail, then the build will fail as well and we'll notice; and can come here and yell^W ask for an update.
Comment 4 Christian Persch 2013-05-28 21:18:41 UTC
It may fail, or not fail but output wrong data. I really think distros should NOT rebuild the source code like this.