After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701055 - keyboard: Wait until fully initialized to show up on the bus
keyboard: Wait until fully initialized to show up on the bus
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-26 16:08 UTC by Rui Matos
Modified: 2013-05-30 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: Wait until fully initialized to show up on the bus (3.11 KB, patch)
2013-05-26 16:08 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2013-05-26 16:08:22 UTC
This seems unlikely to happen but since these paths are async we have
no guarantees otherwise.

I had this patch in a branch that I intended to attach to bug 696996
but forgot (too many branches!).
Comment 1 Rui Matos 2013-05-26 16:08:24 UTC
Created attachment 245339 [details] [review]
keyboard: Wait until fully initialized to show up on the bus

We don't want to get DBus requests until we applied all settings at
least once.
Comment 2 Bastien Nocera 2013-05-30 10:16:16 UTC
Review of attachment 245339 [details] [review]:

Looks good otherwise.

::: plugins/keyboard/gsd-keyboard-manager.c
@@ +1573,3 @@
 
+static void
+localed_proxy_ready (GObject      *source,

Can you make the function move separate from the fix? That would make it much more obvious what the (one-liner) fix is.
Comment 3 Rui Matos 2013-05-30 11:57:30 UTC
Attachment 245339 [details] pushed as 9e7de03 - keyboard: Wait until fully initialized to show up on the bus