After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701051 - should pass -j1 when supports-parallel-builds="no"
should pass -j1 when supports-parallel-builds="no"
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-05-26 14:30 UTC by Adam Dingle
Modified: 2013-05-26 17:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.00 KB, patch)
2013-05-26 14:45 UTC, Adam Dingle 		accepted-commit_now Details | Review

Description Adam Dingle 2013-05-26 14:30:22 UTC 
When a module has supports-parallel-builds="no", currently jhbuild doesn't pass any -j parameter to make.   The problem with this is that I may have MAKEFLAGS set to -j4, for example, in which case the build will still be parallel.  jhbuild should pass -j 1 in this case to explicitly ask for a non-parallel build.
Comment 1 Adam Dingle 2013-05-26 14:45:04 UTC 
Created attachment 245336 [details] [review]
fix

Here's a fix.
Comment 2 Colin Walters 2013-05-26 16:29:34 UTC 
Review of attachment 245336 [details] [review]:

This looks reasonable.
Comment 3 Adam Dingle 2013-05-26 17:56:39 UTC 
Thanks.  I pushed the fix.