After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701028 - Please remove rpath
Please remove rpath
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-26 05:40 UTC by Michael Biebl
Modified: 2013-05-27 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove rpath from Makefile (748 bytes, patch)
2013-05-27 08:47 UTC, Stefano Facchini
committed Details | Review

Description Michael Biebl 2013-05-26 05:40:18 UTC
Encoding an RPATH is in general not a good idea [1]
baobab has one in src/Makefile.am
Please consider applying the following patch

[1] http://wiki.debian.org/RpathIssue

diff --git a/src/Makefile.am b/src/Makefile.am
index afa86f9..8ef1b45 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -62,7 +62,7 @@ AM_CFLAGS = \
        -Wno-unused-variable            \
        $(NULL)
 
-baobab_LDFLAGS = -export-dynamic -rpath $(libdir)
+baobab_LDFLAGS = -export-dynamic
 baobab_LDADD = \
        -lm                             \
        $(BAOBAB_LIBS)
Comment 1 Stefano Facchini 2013-05-26 08:53:01 UTC
Are you experiencing particular problems?

Anyway, I think the -rpath flag is now useless and can be removed, IIRC it was used to help OpenBSD systems in finding libgd (which is now static).

Maybe we should delay the patch after branching, Paolo?
Comment 2 Paolo Borelli 2013-05-26 09:23:51 UTC
Feel free to push the patch, I do not think it requires branching
Comment 3 Michael Biebl 2013-05-27 00:09:33 UTC
Was that directed at me or Stefano?
Comment 4 Paolo Borelli 2013-05-27 06:41:26 UTC
(In reply to comment #3)
> Was that directed at me or Stefano?

If you have committ access go ahead, otherwise me or Stefano will get to it.
Comment 5 Stefano Facchini 2013-05-27 08:47:34 UTC
The following fix has been pushed:
07d944a Remove rpath from Makefile
Comment 6 Stefano Facchini 2013-05-27 08:47:37 UTC
Created attachment 245372 [details] [review]
Remove rpath from Makefile

Encoding a RPATH is in general not a good idea [1].

[1] http://wiki.debian.org/RpathIssue