After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700997 - gnome-clocks: in special cases HeaderBar panel lose its state
gnome-clocks: in special cases HeaderBar panel lose its state
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-25 11:48 UTC by Evgeny Bobkin
Modified: 2013-11-16 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed bugfix (1.34 KB, patch)
2013-11-16 12:09 UTC, Daniel Renninghoff
committed Details | Review
fixes the issue for timers (845 bytes, patch)
2013-11-16 14:32 UTC, Daniel Renninghoff
committed Details | Review

Description Evgeny Bobkin 2013-05-25 11:48:17 UTC
steps to reproduce:

1. set up an alarm to bell in one minute:
2. in the remaining time goto world clocks
3. select one of the clocks
4. wait for alarm to bell
5. alarm changes the header bar state and view to alarms
6. switch to the world clocks view again
7. single clock view had remained and it's not possible anymore to switch to the general clocks overview
Comment 1 Evgeny Bobkin 2013-09-27 20:55:46 UTC
we should investigate it actually someday :-)
Comment 2 Daniel Renninghoff 2013-11-16 12:09:02 UTC
Created attachment 259958 [details] [review]
proposed bugfix

Hi, I found this bug through the GnomeLove wiki (it has been tagged gnome-love) and I fixed this bug (well, atleast I hope so ;)). Here is the patch. Please tell me, if I should change anything (this is my first contribution to the GNOME project).

Cheers
Comment 3 Evgeny Bobkin 2013-11-16 13:04:03 UTC
(In reply to comment #2)
> Created an attachment (id=259958) [details] [review]
> proposed bugfix
> 
> Hi, I found this bug through the GnomeLove wiki (it has been tagged gnome-love)
> and I fixed this bug (well, atleast I hope so ;)). Here is the patch. Please
> tell me, if I should change anything (this is my first contribution to the
> GNOME project).
> 
> Cheers

Hi, thank you for this patch, at first glance it looks good. It's always a pleasure when new contributors join us. If you are interested in clocks development, join us on #gnome-clocks channel and ping me or pbor, there are a lot interesting things which can be improved.
Comment 4 Evgeny Bobkin 2013-11-16 14:20:50 UTC
commited. thank you.
Comment 5 Daniel Renninghoff 2013-11-16 14:32:52 UTC
Created attachment 259965 [details] [review]
fixes the issue for timers

This also happens with timers. This patch fixes that.
Comment 6 Evgeny Bobkin 2013-11-16 15:44:02 UTC
Thank you Daniel.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.