After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700989 - connection editor: disconnect signals from NMClient
connection editor: disconnect signals from NMClient
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-25 05:16 UTC by Matthias Clasen
Modified: 2013-09-07 22:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Disconnect from signal on finalize (1.21 KB, patch)
2013-09-07 17:39 UTC, Bastien Nocera 		committed Details | Review

Description Matthias Clasen 2013-05-25 05:16:01 UTC 
The connection editor connects to permission-changed on its NMClient, but doesn't disconnect from that signal when it drops the NMClient reference in finalize. It should.

This may be the cause for https://bugzilla.redhat.com/attachment.cgi?id=735397
Comment 1 Bastien Nocera 2013-09-07 17:39:55 UTC 
Created attachment 254352 [details] [review]
network: Disconnect from signal on finalize

The connection editor connects to permission-changed on its NMClient,
but didn't disconnect from that signal when dropping the NMClient
reference in finalize.
Comment 2 Rui Matos 2013-09-07 18:03:20 UTC 
Review of attachment 254352 [details] [review]:

Looks good. For 3.8 too
Comment 3 Bastien Nocera 2013-09-07 22:11:19 UTC 
Pushed to master and gnome-3-8

Attachment 254352 [details] pushed as 67f959b - network: Disconnect from signal on finalize