After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700988 - disconnect signal from session proxy
disconnect signal from session proxy
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: updates
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-25 05:11 UTC by Matthias Clasen
Modified: 2013-05-28 10:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
updates: Disconnect session proxy signal handler in finalize (1.14 KB, patch)
2013-05-27 21:56 UTC, Kalev Lember 		committed Details | Review

Description Matthias Clasen 2013-05-25 05:11:31 UTC 
The session proxy is shared across all plugins, so it is possible that it outlives the GsdUpdatesRefresh object. Therefore (and for general cleanliness), you should disconnect the g-signal handler when you  drop your reference to the proxy in dispose.

This might be the reason for https://retrace.fedoraproject.org/faf/problems/786692/
Comment 1 Kalev Lember 2013-05-27 21:56:53 UTC 
Created attachment 245414 [details] [review]
updates: Disconnect session proxy signal handler in finalize

The session proxy can outlive the updates plugin, and then call back
after the updates plugin has already been destroyed, leading to crashes.
Disconnect the signal handler to fix that.
Comment 2 Bastien Nocera 2013-05-28 09:56:41 UTC 
Review of attachment 245414 [details] [review]:

Sure, please commit to gnome-3-8 and master
Comment 3 Kalev Lember 2013-05-28 10:37:03 UTC 
Attachment 245414 [details] pushed as c984d5a - updates: Disconnect session proxy signal handler in finalize