Created attachment 245185 [details] [review]
bluetooth: use bluetooth_client_remove_device()

libgnome-bluetooth now has a method to remove a device, we use it here
now to avoid direct access to the BlueZ API.

Created attachment 245186 [details] [review]
bluetooth: switch_connection is always sensitive

    BlueZ now only has and always has a Connect() method on the Device
    interface so we now let the switch connection button always sensitive.
    
    Any profile can be connected through this method.

Review of attachment 245185 [details] [review]:

I don't like this because I don't really want device management APIs in libgnome-bluetooth.

Review of attachment 245186 [details] [review]:

And what does this do when the device on the other end has no services like audio or input to offer?

Created attachment 245229 [details] [review]
Update adapter interface for BlueZ 5

And move it to a define while at it.

(In reply to comment #5)
> Created an attachment (id=245229) [details] [review]
> Update adapter interface for BlueZ 5
> 
> And move it to a define while at it.

This is an alternative to the patch that uses new API from libgnome-bluetooth.

Review of attachment 245229 [details] [review]:

Looks good.

Created attachment 245798 [details] [review]
 bluetooth: use uuids to set switch_connection sensitiveness

    Since the Services information is now gone, we need to rely on the uuids
    to get the same behaviour.

Created attachment 245800 [details] [review]
bluetooth: use uuids to set switch_connection sensitiveness

    Since the Services information is now gone, we need to rely on the uuids
    to get the same behaviour.

Created attachment 245801 [details] [review]
bluetooth: make the device discoverable when the panel is running

Thus remove the discoverable switch since it is not needed anymore.

Comment on attachment 245229 [details] [review]
Update adapter interface for BlueZ 5

Pushed as ac43647ac01cb990555c7b4ff7b8bf5fb8b17b83

Review of attachment 245800 [details] [review]:

::: panels/bluetooth/cc-bluetooth-panel.c
@@ +62,3 @@
+	"HandsfreeAudioGateway",
+	"HumanInterfaceDeviceService",
+	NULL,

Remove the NULL here...

@@ +324,3 @@
+	int i;
+
+	for (i = 0; connectable_uuids[i] != NULL; i++) {

...and use G_N_ELEMENTS(connectable_uuids); here

@@ +395,3 @@
 					gtk_widget_show (WID ("send_box"));
+
+				if (gtk_widget_get_sensitive(GTK_WIDGET(button)) == FALSE &&

No need to check sensitive == FALSE, it's not stackable.

Review of attachment 245801 [details] [review]:

Marking as rejected as we'll be using the RequestDiscoverable() and ReleaseDiscoverable() API instead.

Created attachment 246093 [details] [review]
bluetooth: use uuids to set switch_connection sensitiveness

    Since the Services information is now gone, we need to rely on the uuids
    to get the same behaviour.

Created attachment 246184 [details] [review]
bluetooth: use uuids to set switch_connection sensitiveness

    Since the Services information is now gone, we need to rely on the uuids
    to get the same behaviour.

Review of attachment 246184 [details] [review]:

::: panels/bluetooth/cc-bluetooth-panel.c
@@ +52,3 @@
 #define WIZARD			"bluetooth-wizard"
 
+static const char *connectable_uuids[] = {

As discussed on IRC, I'd rather this list was in libgnome-bluetooth.

Created attachment 246553 [details] [review]
bluetooth: use uuids to set switch_connection sensitiveness

    Since the Services information is now gone, we need to rely on the uuids
    to get the same behaviour.

Created attachment 246558 [details] [review]
bluetooth: use uuids to set switch_connection sensitiveness

Since the Services information is now gone, we need to rely on the uuids
    to get the same behaviour.

Review of attachment 246558 [details] [review]:

::: panels/bluetooth/cc-bluetooth-panel.c
@@ +371,3 @@
+
+			gtk_widget_set_sensitive (GTK_WIDGET(button),
+				bluetooth_client_get_connectable(uuids));

indentation, and space before the bracket. Looks fine otherwise.

Attachment 246558 [details] pushed as c7b02d7 - bluetooth: use uuids to set switch_connection sensitiveness