After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700807 - userWidget: Fix leaking instances
userWidget: Fix leaking instances
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-21 19:42 UTC by Rui Matos
Modified: 2013-05-21 20:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
userWidget: Fix leaking instances (1.47 KB, patch)
2013-05-21 19:42 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-05-21 19:42:57 UTC 
Noticed this because of

(lt-gnome-shell-real:13106): Clutter-CRITICAL **: clutter_text_get_editable: assertion `CLUTTER_IS_TEXT (self)' failed

(lt-gnome-shell-real:13106): Clutter-CRITICAL **: clutter_text_get_text: assertion `CLUTTER_IS_TEXT (self)' failed

(lt-gnome-shell-real:13106): Clutter-CRITICAL **: clutter_text_set_text: assertion `CLUTTER_IS_TEXT (self)' failed

while changing the user account language in g-c-c after having locked
and unlocked the session at least once.
Comment 1 Rui Matos 2013-05-21 19:42:59 UTC 
Created attachment 244990 [details] [review]
userWidget: Fix leaking instances

UserWidget instances should be destroyed when the actor is. That's
what consumer code expects since the destroy() method is never called.
Comment 2 Giovanni Campagna 2013-05-21 19:46:23 UTC 
Review of attachment 244990 [details] [review]:

We should really move to inheriting from StWidget and overriding vfunc_destroy()...
Comment 3 Giovanni Campagna 2013-05-21 19:46:23 UTC 
Review of attachment 244990 [details] [review]:

We should really move to inheriting from StWidget and overriding vfunc_destroy()...
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-05-21 19:49:03 UTC 
Review of attachment 244990 [details] [review]:

We tend to call the signal handlers "_onDestroy" in this case.
Comment 5 Rui Matos 2013-05-21 20:00:13 UTC 
Pushed to master and 3.8 with Jasper's comment addressed.

Attachment 244990 [details] pushed as 3754a76 - userWidget: Fix leaking instances