GNOME Bugzilla – Bug 700776
Licensing problems
Last modified: 2013-08-19 00:56:29 UTC
2 major problems with the gnome-music licensing: - It lacks a COPYING file to be used as a project-wide license, meaning that some files don't contain license information (all the data files such as .ui files) - The license for the majority of files (GPLv2+) is incompatible with playing back audio using proprietary GStreamer plugins. See Totem and Rhythmbox' licenses for example.
Thanks on it
Created attachment 245382 [details] [review] Add COPYING file
Bastien, et al, I've reviewed the licenses for both Rhythmbox & Totem. Rhythmbox has a standard GPL v2 license without any mention of proprietary plugins, however Totem's includes a single line at the end: "Totem contains an exception to allow the use of proprietary GStreamer plugins." I assume that we could do the same in GNOME-Music. I will be reviewing individual files in GNOME-Music over the next day or two as well as researching other licensing possibilities.
https://git.gnome.org/browse/rhythmbox/tree/COPYING#n345
What's wrong with Vadim's posted above? It's the exact same as Rthymbox's COPYING file with the names/authors changed.
(In reply to comment #3) > Rhythmbox has a standard GPL v2 license without any mention of proprietary > plugins, <snip> Which is completely incorrect?
Agree with Bastien, RB has the exception (https://git.gnome.org/browse/rhythmbox/tree/COPYING#n345) and the proposed patch is basically a copy of it with replacement of authors and names. Emily, could you review the patch, as Bastien has confirmed that this license fits.
Emily we also need a +1 from every contributor to change the license. Can you go through the files and look at the contributors and then send a mail to all of us so we can +1 it? Cheers Seif
I have sent mail to everyone who has ever committed anything to gnome-music to approve the license change.
I here grant +1 to the license change
+1
My contribution is hardly relevant for copyright, but sure - no objections from my side.
For the benefit of the gnome-music users, I approve the license change. Thank you and congratulations for striving to make the user experience even better! +1 vote
I'm fine with the license change.
+1 for the license change.
Obviously fine (although my code is BSD licensed, so it's irrelevant)
Another +1
OK too.
License change approved
+1 for license change.
If I recall correctly, I've done a one-line-fix to gnome-music at most, but +1 from me regardless.
I'm the author of the first Vala try on gnome-music. I'm completely OK with the license change.
My trivial contribution can be relicensed. By the way, ever source file will have to carry the changed license as well, and I don't see those necessary in the patch.
Created attachment 247492 [details] [review] Add COPYING file Update source file license and copyrights
Review of attachment 245382 [details] [review]: Replaced
Created attachment 247493 [details] [review] Request half-screen size, the app now fits half maximized tile mode https://bugzilla.gnome.org/show_bug.cgi?id=700022
Review of attachment 247493 [details] [review]: Wrong patch, sorry
In addition, I found a third licensing-related problem. The copyright header for all files under the GPLv2+ license in the src/ folder (i.e all except package.js) is incorrect: * Gnome Music is free software; you can Public License as published by the * Free Software Foundation; either version 2 of the License, or (at your * option) any later version. It seems like a few words are missing. :)
Created attachment 249262 [details] [review] Add COPYING file Update source file license and copyrights
Review of attachment 249262 [details] [review]: ::: src/albumArtCache.js @@ +9,2 @@ * + * Gnome Music is free software; you can you can redistribute it and/or modify "you can you can"? :) (same for other files)
Created attachment 249264 [details] [review] Add COPYING file Update source file license and copyrights (fixed typo)
The following fix has been pushed: 35cb714 Add COPYING file
Created attachment 249472 [details] [review] Add COPYING file Update source file license and copyrights (fixed typo)
Reopnening, lost this during python port
Created attachment 252143 [details] [review] Patch to add license Missing Lubosz Sarnecki's email (in albumArtCache.py and application.py), but otherwise complete.
Review of attachment 252143 [details] [review]: Could you please use "git format-patch" so that this patch would be named as yours? Also, use Python comments for the license notices. The dot in the end of each Copyright lines are unnecessary. Sample for query.py: # Copyright (c) 2013 Arnel A Borja <kyoushuu@yahoo.com> # Copyright (c) 2013 Vadim Rutkovsky <roignac@gmail.com> # Copyright (c) 2013 Seif Lotfy <seif@lotfy.com> # Copyright (c) 2013 Guillaume Quintard <guillaume.quintard@gmail.com> # # Gnome Music is free software; you can Public License as published by the # Free Software Foundation; either version 2 of the License, or (at your # option) any later version. # # Gnome Music is distributed in the hope that it will be useful, but # WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY # or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License # for more details. # # You should have received a copy of the GNU General Public License along # with Gnome Music; if not, write to the Free Software Foundation, # Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ::: gnomemusic/albumArtCache.py @@ +4,3 @@ + * Copyright (c) 2013 Seif Lotfy <seif@lotfy.com> + * Copyright (c) 2013 Guillaume Quintard <guillaume.quintard@gmail.com>. + * Copyright (c) 2013 Lubosz Sarnecki <>. Missing e-mail: lubosz@gmail.com according to git logs. ::: gnomemusic/application.py @@ +2,3 @@ + * Copyright (c) 2013 Arnel A Borja <kyoushuu@yahoo.com>. + * Copyright (c) 2013 Vadim Rutkovsky <vrutkovs@redhat.com>. + * Copyright (c) 2013 Lubosz Sarnecki Same as above.
Created attachment 252149 [details] [review] Patch to update licenses updated license.patch file
Comment on attachment 252149 [details] [review] Patch to update licenses Committed as: commit 25d7e5a069a59e32b4b06bf3d7b3f0c27ae63ad5 Author: Emily Gonyer <emilyyrose@gmail.com> Date: Mon Aug 19 02:20:00 2013 +0800 Add source file license notices https://bugzilla.gnome.org/show_bug.cgi?id=700776 I made changes to my name (changed it to Arnel A. Borja). Also I removed the empty comment lines on top and bottom and changed it to have 2 newlines after each license notice so that pep8 would be happy.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.