After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700776 - Licensing problems
Licensing problems
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: High major
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-21 12:15 UTC by Bastien Nocera
Modified: 2013-08-19 00:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add COPYING file (18.99 KB, patch)
2013-05-27 12:14 UTC, Vadim Rutkovsky
rejected Details | Review
Add COPYING file (33.86 KB, patch)
2013-06-21 20:40 UTC, Vadim Rutkovsky
none Details | Review
Request half-screen size, the app now fits half maximized tile mode (2.69 KB, patch)
2013-06-21 21:40 UTC, Vadim Rutkovsky
rejected Details | Review
Add COPYING file (35.54 KB, patch)
2013-07-16 10:12 UTC, Vadim Rutkovsky
none Details | Review
Add COPYING file (35.48 KB, patch)
2013-07-16 11:01 UTC, Vadim Rutkovsky
committed Details | Review
Add COPYING file (35.48 KB, patch)
2013-07-18 08:13 UTC, Vadim Rutkovsky
committed Details | Review
Patch to add license (14.19 KB, patch)
2013-08-18 17:17 UTC, Emily Gonyer
needs-work Details | Review
Patch to update licenses (13.76 KB, patch)
2013-08-18 18:20 UTC, Emily Gonyer
committed Details | Review

Description Bastien Nocera 2013-05-21 12:15:11 UTC
2 major problems with the gnome-music licensing:
- It lacks a COPYING file to be used as a project-wide license, meaning that some files don't contain license information (all the data files such as .ui files)
- The license for the majority of files (GPLv2+) is incompatible with playing back audio using proprietary GStreamer plugins. See Totem and Rhythmbox' licenses for example.
Comment 1 Seif Lotfy 2013-05-21 12:21:18 UTC
Thanks on it
Comment 2 Vadim Rutkovsky 2013-05-27 12:14:36 UTC
Created attachment 245382 [details] [review]
Add COPYING file
Comment 3 Emily Gonyer 2013-05-30 19:04:09 UTC
Bastien, et al, I've reviewed the licenses for both Rhythmbox & Totem. Rhythmbox has a standard GPL v2 license without any mention of proprietary plugins, however Totem's includes a single line at the end: 

"Totem contains an exception to allow the use of proprietary GStreamer plugins."

I assume that we could do the same in GNOME-Music. I will be reviewing individual files in GNOME-Music over the next day or two as well as researching other licensing possibilities.
Comment 5 Emily Gonyer 2013-05-31 04:04:25 UTC
What's wrong with Vadim's posted above? It's the exact same as Rthymbox's COPYING file with the names/authors changed.
Comment 6 Bastien Nocera 2013-05-31 09:11:42 UTC
(In reply to comment #3)
> Rhythmbox has a standard GPL v2 license without any mention of proprietary
> plugins,
<snip>

Which is completely incorrect?
Comment 7 Vadim Rutkovsky 2013-05-31 09:34:26 UTC
Agree with Bastien, RB has the exception (https://git.gnome.org/browse/rhythmbox/tree/COPYING#n345) and the proposed patch is basically a copy of it with replacement of authors and names.

Emily, could you review the patch, as Bastien has confirmed that this license fits.
Comment 8 Seif Lotfy 2013-06-04 11:56:32 UTC
Emily we also need a +1 from every contributor to change the license. Can you go through the files and look at the contributors and then send a mail to all of us so we can +1 it?
Cheers
Seif
Comment 9 Sri Ramkrishna 2013-06-07 17:21:14 UTC
I have sent mail to everyone who has ever committed anything to gnome-music to approve the license change.
Comment 10 Juan A. Suarez Romero 2013-06-07 17:23:40 UTC
I here grant +1 to the license change
Comment 11 Jakub Steiner 2013-06-07 17:28:08 UTC
+1
Comment 12 Florian Müllner 2013-06-07 17:28:39 UTC
My contribution is hardly relevant for copyright, but sure - no objections from my side.
Comment 13 Enrico Nicoletto 2013-06-07 17:40:20 UTC
For the benefit of the gnome-music users, I approve the license change.

Thank you and congratulations for striving to make the user experience even better!

+1 vote
Comment 14 Florian Will 2013-06-07 18:06:42 UTC
I'm fine with the license change.
Comment 15 Shivani Poddar 2013-06-07 18:13:31 UTC
+1 for the license change.
Comment 16 Sai Suman Prayaga 2013-06-07 18:46:58 UTC
+1
Comment 17 Piotr Drąg 2013-06-07 19:03:56 UTC
+1
Comment 18 William Jon McCann 2013-06-07 19:19:31 UTC
I'm fine with the license change.
Comment 19 Giovanni Campagna 2013-06-07 19:59:51 UTC
Obviously fine (although my code is BSD licensed, so it's irrelevant)
Comment 20 Fran Diéguez 2013-06-07 20:12:12 UTC
+1
Comment 21 Eslam Mostafa 2013-06-07 20:16:42 UTC
+1
Comment 22 Muhammet Kara 2013-06-07 20:18:24 UTC
+1
Comment 23 Daniel Mustieles 2013-06-07 20:25:02 UTC
Another +1
Comment 24 guillaume quintard 2013-06-07 22:37:55 UTC
OK too.
Comment 25 Allan Day 2013-06-07 23:53:07 UTC
+1
Comment 26 Seif Lotfy 2013-06-08 07:26:17 UTC
+1
Comment 27 Timo Jyrinki 2013-06-08 07:44:49 UTC
+1
Comment 28 Arnel Borja 2013-06-08 07:46:05 UTC
+1
Comment 29 A S Alam 2013-06-08 11:40:39 UTC
+1
Comment 30 Vadim Rutkovsky 2013-06-09 13:54:46 UTC
License change approved
Comment 31 Milo Casagrande 2013-06-10 06:55:54 UTC
+1 for license change.
Comment 32 Andreas Nilsson 2013-06-10 08:13:47 UTC
If I recall correctly, I've done a one-line-fix to gnome-music at most, but +1 from me regardless.
Comment 33 Wylmer Wang 2013-06-11 01:35:32 UTC
+1
Comment 34 Cesar Garcia Tapia 2013-06-11 08:03:28 UTC
I'm the author of the first Vala try on gnome-music. I'm completely OK with the license change.
Comment 35 Bastien Nocera 2013-06-11 10:20:27 UTC
My trivial contribution can be relicensed.

By the way, ever source file will have to carry the changed license as well, and I don't see those necessary in the patch.
Comment 36 Vadim Rutkovsky 2013-06-21 20:40:07 UTC
Created attachment 247492 [details] [review]
Add COPYING file

Update source file license and copyrights
Comment 37 Vadim Rutkovsky 2013-06-21 20:40:32 UTC
Review of attachment 245382 [details] [review]:

Replaced
Comment 38 Vadim Rutkovsky 2013-06-21 21:40:23 UTC
Created attachment 247493 [details] [review]
Request half-screen size, the app now fits half maximized tile mode

https://bugzilla.gnome.org/show_bug.cgi?id=700022
Comment 39 Vadim Rutkovsky 2013-06-21 21:42:05 UTC
Review of attachment 247493 [details] [review]:

Wrong patch, sorry
Comment 40 Fabiano Fidêncio 2013-06-25 23:31:12 UTC
+1
Comment 41 Mathieu Bridon 2013-07-13 12:35:38 UTC
In addition, I found a third licensing-related problem.

The copyright header for all files under the GPLv2+ license in the src/ folder (i.e all except package.js) is incorrect:

 * Gnome Music is free software; you can Public License as published by the
 * Free Software Foundation; either version 2 of the License, or (at your
 * option) any later version.

It seems like a few words are missing. :)
Comment 42 Vadim Rutkovsky 2013-07-16 10:12:25 UTC
Created attachment 249262 [details] [review]
Add COPYING file

Update source file license and copyrights
Comment 43 Mathieu Bridon 2013-07-16 10:14:47 UTC
Review of attachment 249262 [details] [review]:

::: src/albumArtCache.js
@@ +9,2 @@
  *
+ * Gnome Music is free software; you can you can redistribute it and/or modify

"you can you can"? :)

(same for other files)
Comment 44 Vadim Rutkovsky 2013-07-16 11:01:25 UTC
Created attachment 249264 [details] [review]
Add COPYING file

Update source file license and copyrights (fixed typo)
Comment 45 Vadim Rutkovsky 2013-07-18 08:13:37 UTC
The following fix has been pushed:
35cb714 Add COPYING file
Comment 46 Vadim Rutkovsky 2013-07-18 08:13:49 UTC
Created attachment 249472 [details] [review]
Add COPYING file

Update source file license and copyrights (fixed typo)
Comment 47 Vadim Rutkovsky 2013-08-12 15:23:52 UTC
Reopnening, lost this during python port
Comment 48 Emily Gonyer 2013-08-18 17:17:59 UTC
Created attachment 252143 [details] [review]
Patch to add license

Missing Lubosz Sarnecki's email (in albumArtCache.py and application.py), but otherwise complete.
Comment 49 Arnel Borja 2013-08-18 17:29:06 UTC
Review of attachment 252143 [details] [review]:

Could you please use "git format-patch" so that this patch would be named as yours?

Also, use Python comments for the license notices. The dot in the end of each Copyright lines are unnecessary.

Sample for query.py:
# Copyright (c) 2013 Arnel A Borja <kyoushuu@yahoo.com>
# Copyright (c) 2013 Vadim Rutkovsky <roignac@gmail.com>
# Copyright (c) 2013 Seif Lotfy <seif@lotfy.com>
# Copyright (c) 2013 Guillaume Quintard <guillaume.quintard@gmail.com>
#
# Gnome Music is free software; you can Public License as published by the
# Free Software Foundation; either version 2 of the License, or (at your
# option) any later version.
#
# Gnome Music is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
# or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
# for more details.
#
# You should have received a copy of the GNU General Public License along
# with Gnome Music; if not, write to the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA

::: gnomemusic/albumArtCache.py
@@ +4,3 @@
+ * Copyright (c) 2013 Seif Lotfy <seif@lotfy.com>
+ * Copyright (c) 2013 Guillaume Quintard <guillaume.quintard@gmail.com>.
+ * Copyright (c) 2013 Lubosz Sarnecki <>.

Missing e-mail: lubosz@gmail.com according to git logs.

::: gnomemusic/application.py
@@ +2,3 @@
+ * Copyright (c) 2013 Arnel A Borja <kyoushuu@yahoo.com>.
+ * Copyright (c) 2013 Vadim Rutkovsky <vrutkovs@redhat.com>.
+ * Copyright (c) 2013 Lubosz Sarnecki

Same as above.
Comment 50 Emily Gonyer 2013-08-18 18:20:16 UTC
Created attachment 252149 [details] [review]
Patch to update licenses

updated license.patch file
Comment 51 Arnel Borja 2013-08-19 00:55:46 UTC
Comment on attachment 252149 [details] [review]
Patch to update licenses

Committed as:

commit 25d7e5a069a59e32b4b06bf3d7b3f0c27ae63ad5
Author: Emily Gonyer <emilyyrose@gmail.com>
Date:   Mon Aug 19 02:20:00 2013 +0800

    Add source file license notices
    
    https://bugzilla.gnome.org/show_bug.cgi?id=700776


I made changes to my name (changed it to Arnel A. Borja). Also I removed the empty comment lines on top and bottom and changed it to have 2 newlines after each license notice so that pep8 would be happy.
Comment 52 Arnel Borja 2013-08-19 00:56:29 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.