After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700774 - press F5 to reload
press F5 to reload
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other Linux
: Normal normal
: ---
Assigned To: Sindhu S
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-21 11:44 UTC by Adam Dingle
Modified: 2014-07-13 01:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add F5 also as keyboard shortcut to reload repository (816 bytes, patch)
2013-05-21 12:29 UTC, Sindhu S 		accepted-commit_now Details | Review
Fix reload shortcuts (2.01 KB, patch)
2013-05-21 15:40 UTC, Sindhu S 		rejected Details | Review

Description Adam Dingle 2013-05-21 11:44:41 UTC 
It's nice that I can now press Ctrl+R to reload the current view in Gitg.  I'd also like to be able to press F5 to reload, for consistency with Nautilus and Epiphany which both support that alternative shortcut.
Comment 1 Sindhu S 2013-05-21 12:29:14 UTC 
Created attachment 244913 [details] [review]
Add F5 also as keyboard shortcut to reload repository
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-05-21 12:42:04 UTC 
Review of attachment 244913 [details] [review]:

Looks good.
Comment 3 Sindhu S 2013-05-21 13:32:45 UTC 
Pushed to master in ca15b15a79addf27c259d9b3d01dbee91d34d26f

Available at https://git.gnome.org/browse/gitg/commit/?id=ca15b15a79addf27c259d9b3d01dbee91d34d26f

Closing bug now, Thanks.
Comment 4 Adam Dingle 2013-05-21 13:40:27 UTC 
It now seems that Ctrl+R is not working.  We want both Ctrl+R and F5 to work.  Reopening.
Comment 5 Sindhu S 2013-05-21 15:40:30 UTC 
Created attachment 244938 [details] [review]
Fix reload shortcuts

Please test with this patch. Thanks.
Comment 6 Adam Dingle 2013-05-21 22:50:28 UTC 
(In reply to comment #5)
> Created an attachment (id=244938) [details] [review]
> Fix reload shortcuts
> 
> Please test with this patch. Thanks.

Seems to work fine!
Comment 7 Ignacio Casal Quinteiro (nacho) 2013-05-23 14:55:39 UTC 
Review of attachment 244938 [details] [review]:

This is not the right way to do it. Ryan is working on it so we should wait until he gets this in.
Comment 8 Adam Dingle 2013-05-23 14:57:19 UTC 
Can we look at the code for Epiphany or Nautilus, which support both these shortcuts, and do what they do?
Comment 9 Ignacio Casal Quinteiro (nacho) 2013-05-23 14:59:58 UTC 
I spoke with desrt and he is working on this. Also nautilus is still using GtkUIManager and probably epiphany too.
Comment 10 Adam Dingle 2013-05-23 15:09:57 UTC 
OK - good to know.
Comment 11 Sindhu S 2013-09-09 02:48:51 UTC 
What's the update on this?
Comment 12 jessevdk@gmail.com 2014-07-13 01:29:01 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.