After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700729 - It is possible to search for an "empty" string
It is possible to search for an "empty" string
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-20 16:12 UTC by Chris Cummins
Modified: 2013-05-27 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't search for "empty" strings (1.64 KB, patch)
2013-05-20 16:15 UTC, Chris Cummins 		committed Details | Review
Screenshot showing the results from a white-space search query (30.12 KB, image/png)
2013-05-23 10:42 UTC, Chris Cummins 		  Details

Description Chris Cummins 2013-05-20 16:12:36 UTC 
Typing a space in the search query box returns a search query containing all contacts. There is no validation of the search query to ensure that it contains useful characters (not just whitespace).
Comment 1 Chris Cummins 2013-05-20 16:15:55 UTC 
Created attachment 244832 [details] [review]
Don't search for "empty" strings

This ensures that a search is only performed if the query string contains at least one non-space character, so typing space in the search box no longer returns all contacts.
Comment 2 Chris Cummins 2013-05-23 10:42:47 UTC 
Created attachment 245115 [details]
Screenshot showing the results from a white-space search query

This demonstrates that pressing the spacebar in the search query field returns a list of all the contacts in the address book (names obscured).