After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700726 - only checks for new music at start
only checks for new music at start
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.9.x
Other Linux
: High normal
: ---
Assigned To: Sai Suman Prayaga
gnome-music-maint
: 706534 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-05-20 15:53 UTC by William Jon McCann
Modified: 2014-04-17 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Attachment for the patch (4.99 KB, patch)
2014-03-03 18:40 UTC, Sai Suman Prayaga
needs-work Details | Review
Update views when songs are being added or deleted. (10.68 KB, patch)
2014-03-06 22:11 UTC, Sai Suman Prayaga
committed Details | Review

Description William Jon McCann 2013-05-20 15:53:06 UTC
I added music to my Music folder and the app didn't notice. It only showed up after restarting the app.
Comment 1 Arnel Borja 2013-08-20 02:42:31 UTC
A possible fix for Songs view would be using a GtkTreeModelSort then get the tracks from Tracker via queries sorted by the time they were added. This needs some changes to libgd though because GdMainView currently accepts only GtkTreeModelFilter or GtkListStore. This might work on albums or artists view too, but I haven't looked much into it yet.

Another alternative suggested by Allan Day would be to have a "Refresh Library" button.
Comment 2 Arnel Borja 2013-08-22 04:11:35 UTC
*** Bug 706534 has been marked as a duplicate of this bug. ***
Comment 3 Matthias Clasen 2013-09-08 17:01:26 UTC
any update on this ?
Comment 4 Matthias Clasen 2013-09-10 19:34:55 UTC
not going to happen for 3.10, I assume
Comment 5 Arnel Borja 2013-09-11 15:20:24 UTC
I'm having a problem with how the tracker queries return albums, so I can't fix it for now. Sai is trying out a different approach, but he thinks it won't make it into 3.10.

We might fix the Songs view, but we probably can't fix it in the other views for this cycle.
Comment 6 Sai Suman Prayaga 2014-03-03 18:40:34 UTC
Created attachment 270833 [details] [review]
Attachment for the patch
Comment 7 Vadim Rutkovsky 2014-03-04 09:38:06 UTC
Review of attachment 270833 [details] [review]:

Good, its a nice start, however it doesn't update removed albums/artists in the view (album/artist is displayed empty)
Comment 8 Sai Suman Prayaga 2014-03-06 22:11:14 UTC
Created attachment 271148 [details] [review]
Update views when songs are being added or deleted.
Comment 9 Vadim Rutkovsky 2014-03-07 10:05:04 UTC
Review of attachment 271148 [details] [review]:

Good, tested this a bit and it works (I think we can address other issues in new bugs). Pushed as https://git.gnome.org/browse/gnome-music/commit/?id=5d16c7b
Comment 10 Vadim Rutkovsky 2014-03-19 14:38:53 UTC
The fix caused a regression - bug 726713
Comment 11 Vadim Rutkovsky 2014-04-17 17:48:50 UTC
Closing as works, regression will be handled in a different bug